Re: [PATCH] of: mtd: nuke useless const qualifier

2012-07-10 Thread Bityutskiy, Artem
On Tue, 2012-07-10 at 10:35 -0500, Rob Herring wrote: > > Remove also the unnecessary "extern" qualifier to be consistent with other > > declarations in this file. > > > > Signed-off-by: Artem Bityutskiy > > --- > > Applied. Next time please don't PGP sign patches. Thanks. Sure, I'll try. --

Re: [PATCH] of: mtd: nuke useless const qualifier

2012-07-10 Thread Rob Herring
On 07/10/2012 08:35 AM, Bityutskiy, Artem wrote: > From: Artem Bityutskiy > > This patch does the following: > -const int of_get_nand_ecc_mode(struct device_node *np) > +int of_get_nand_ecc_mode(struct device_node *np) > > because: > 1. it is probably just a typo? > 2. it causes warnings like

[PATCH] of: mtd: nuke useless const qualifier

2012-07-10 Thread Bityutskiy, Artem
From: Artem Bityutskiy This patch does the following: -const int of_get_nand_ecc_mode(struct device_node *np) +int of_get_nand_ecc_mode(struct device_node *np) because: 1. it is probably just a typo? 2. it causes warnings like this when people assing the returned value to an 'int'

[PATCH] of: mtd: nuke useless const qualifier

2012-07-10 Thread Bityutskiy, Artem
From: Artem Bityutskiy artem.bityuts...@linux.intel.com This patch does the following: -const int of_get_nand_ecc_mode(struct device_node *np) +int of_get_nand_ecc_mode(struct device_node *np) because: 1. it is probably just a typo? 2. it causes warnings like this when people assing the

Re: [PATCH] of: mtd: nuke useless const qualifier

2012-07-10 Thread Rob Herring
On 07/10/2012 08:35 AM, Bityutskiy, Artem wrote: From: Artem Bityutskiy artem.bityuts...@linux.intel.com This patch does the following: -const int of_get_nand_ecc_mode(struct device_node *np) +int of_get_nand_ecc_mode(struct device_node *np) because: 1. it is probably just a typo? 2.

Re: [PATCH] of: mtd: nuke useless const qualifier

2012-07-10 Thread Bityutskiy, Artem
On Tue, 2012-07-10 at 10:35 -0500, Rob Herring wrote: Remove also the unnecessary extern qualifier to be consistent with other declarations in this file. Signed-off-by: Artem Bityutskiy artem.bityuts...@linux.intel.com --- Applied. Next time please don't PGP sign patches. Thanks.