Re: [PATCH] of: overlay: validate offset from property fixups

2018-05-23 Thread Rob Herring
On Wed, May 16, 2018 at 09:19:51PM -0700, frowand.l...@gmail.com wrote: > From: Frank Rowand > > The smatch static checker marks the data in offset as untrusted, > leading it to warn: > > drivers/of/resolver.c:125 update_usages_of_a_phandle_reference() > error: buffer

Re: [PATCH] of: overlay: validate offset from property fixups

2018-05-23 Thread Rob Herring
On Wed, May 16, 2018 at 09:19:51PM -0700, frowand.l...@gmail.com wrote: > From: Frank Rowand > > The smatch static checker marks the data in offset as untrusted, > leading it to warn: > > drivers/of/resolver.c:125 update_usages_of_a_phandle_reference() > error: buffer underflow

Re: [PATCH] of: overlay: validate offset from property fixups

2018-05-17 Thread Frank Rowand
On 05/17/18 09:56, Frank Rowand wrote: > Hi Rob, > > On 05/16/18 21:19, frowand.l...@gmail.com wrote: >> From: Frank Rowand >> >> The smatch static checker marks the data in offset as untrusted, >> leading it to warn: >> >> drivers/of/resolver.c:125

Re: [PATCH] of: overlay: validate offset from property fixups

2018-05-17 Thread Frank Rowand
On 05/17/18 09:56, Frank Rowand wrote: > Hi Rob, > > On 05/16/18 21:19, frowand.l...@gmail.com wrote: >> From: Frank Rowand >> >> The smatch static checker marks the data in offset as untrusted, >> leading it to warn: >> >> drivers/of/resolver.c:125 update_usages_of_a_phandle_reference() >>

Re: [PATCH] of: overlay: validate offset from property fixups

2018-05-17 Thread Frank Rowand
Hi Rob, On 05/16/18 21:19, frowand.l...@gmail.com wrote: > From: Frank Rowand > > The smatch static checker marks the data in offset as untrusted, > leading it to warn: > > drivers/of/resolver.c:125 update_usages_of_a_phandle_reference() > error: buffer underflow

Re: [PATCH] of: overlay: validate offset from property fixups

2018-05-17 Thread Frank Rowand
Hi Rob, On 05/16/18 21:19, frowand.l...@gmail.com wrote: > From: Frank Rowand > > The smatch static checker marks the data in offset as untrusted, > leading it to warn: > > drivers/of/resolver.c:125 update_usages_of_a_phandle_reference() > error: buffer underflow 'prop->value'

[PATCH] of: overlay: validate offset from property fixups

2018-05-16 Thread frowand . list
From: Frank Rowand The smatch static checker marks the data in offset as untrusted, leading it to warn: drivers/of/resolver.c:125 update_usages_of_a_phandle_reference() error: buffer underflow 'prop->value' 's32min-s32max' Add check to verify that offset is within

[PATCH] of: overlay: validate offset from property fixups

2018-05-16 Thread frowand . list
From: Frank Rowand The smatch static checker marks the data in offset as untrusted, leading it to warn: drivers/of/resolver.c:125 update_usages_of_a_phandle_reference() error: buffer underflow 'prop->value' 's32min-s32max' Add check to verify that offset is within the property data.