Re: [PATCH] omapfb: panel-tpo-td043mtea1: constify attribute_group structures.

[Bartlomiej Zolnierkiewicz]

On Wednesday, July 19, 2017 10:53:11 AM Arvind Yadav wrote:
> attribute_group are not supposed to change at runtime. All functions
> working with attribute_group provided by  work
> with const attribute_group. So mark the non-const structs as const.
> 
> File size before:
>text  data bss dec hex filename
>2673   368   03041 be1 panel-tpo-td043mtea1.o
> 
> File size After adding 'const':
>text  data bss dec hex filename
>2737   304   03041 be1 panel-tpo-td043mtea1.o
> 
> Signed-off-by: Arvind Yadav 

Patch queued for 4.14, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R Institute Poland
Samsung Electronics

Re: [PATCH] omapfb: panel-tpo-td043mtea1: constify attribute_group structures.

[Bartlomiej Zolnierkiewicz]

On Wednesday, July 19, 2017 10:53:11 AM Arvind Yadav wrote:
> attribute_group are not supposed to change at runtime. All functions
> working with attribute_group provided by  work
> with const attribute_group. So mark the non-const structs as const.
> 
> File size before:
>text  data bss dec hex filename
>2673   368   03041 be1 panel-tpo-td043mtea1.o
> 
> File size After adding 'const':
>text  data bss dec hex filename
>2737   304   03041 be1 panel-tpo-td043mtea1.o
> 
> Signed-off-by: Arvind Yadav 

Patch queued for 4.14, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R Institute Poland
Samsung Electronics

[PATCH] omapfb: panel-tpo-td043mtea1: constify attribute_group structures.

[Arvind Yadav]

attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by  work
with const attribute_group. So mark the non-const structs as const.

File size before:
   textdata bss dec hex filename
   2673 368   03041 be1 panel-tpo-td043mtea1.o

File size After adding 'const':
   textdata bss dec hex filename
   2737 304   03041 be1 panel-tpo-td043mtea1.o

Signed-off-by: Arvind Yadav 
---
 drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c 
b/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c
index 51e628b..ea8c79a 100644
--- a/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c
+++ b/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c
@@ -282,7 +282,7 @@ static DEVICE_ATTR(gamma, S_IRUGO | S_IWUSR,
NULL,
 };
 
-static struct attribute_group tpo_td043_attr_group = {
+static const struct attribute_group tpo_td043_attr_group = {
.attrs = tpo_td043_attrs,
 };
 
-- 
1.9.1

[PATCH] omapfb: panel-tpo-td043mtea1: constify attribute_group structures.

[Arvind Yadav]

attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by  work
with const attribute_group. So mark the non-const structs as const.

File size before:
   textdata bss dec hex filename
   2673 368   03041 be1 panel-tpo-td043mtea1.o

File size After adding 'const':
   textdata bss dec hex filename
   2737 304   03041 be1 panel-tpo-td043mtea1.o

Signed-off-by: Arvind Yadav 
---
 drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c 
b/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c
index 51e628b..ea8c79a 100644
--- a/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c
+++ b/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c
@@ -282,7 +282,7 @@ static DEVICE_ATTR(gamma, S_IRUGO | S_IWUSR,
NULL,
 };
 
-static struct attribute_group tpo_td043_attr_group = {
+static const struct attribute_group tpo_td043_attr_group = {
.attrs = tpo_td043_attrs,
 };
 
-- 
1.9.1