Re: [PATCH] opp: Add API for getting voltage from supplies

2018-12-13 Thread Nick Fan
On Thu, 2018-12-13 at 16:12 +0530, Viresh Kumar wrote: > On 13-12-18, 18:36, Nick Fan wrote: > > This new API is suitable for the users that required to access for > > multiple regulators. And I am one of users who uses this API, but I am > > not able to upstream the GPU kernel driver which uses th

Re: [PATCH] opp: Add API for getting voltage from supplies

2018-12-13 Thread Viresh Kumar
On 13-12-18, 18:36, Nick Fan wrote: > This new API is suitable for the users that required to access for > multiple regulators. And I am one of users who uses this API, but I am > not able to upstream the GPU kernel driver which uses the new API. Look at it from mainline's perspective.. - We don'

Re: [PATCH] opp: Add API for getting voltage from supplies

2018-12-13 Thread Nick Fan
On Thu, 2018-12-13 at 12:08 +0530, Viresh Kumar wrote: > On 10-12-18, 20:36, Nick Fan wrote: > > For the users who only use one supply, they can use > > dev_pm_opp_get_voltage to get the voltage data from an opp. > > But if the users who use more than one supply, they will need this API > > to get

Re: [PATCH] opp: Add API for getting voltage from supplies

2018-12-12 Thread Viresh Kumar
On 10-12-18, 20:36, Nick Fan wrote: > For the users who only use one supply, they can use > dev_pm_opp_get_voltage to get the voltage data from an opp. > But if the users who use more than one supply, they will need this API > to get their voltage data from OPP. > The users should know about the su

Re: [PATCH] opp: Add API for getting voltage from supplies

2018-12-10 Thread Nick Fan
On Tue, 2018-12-04 at 13:51 +0530, Viresh Kumar wrote: > On 04-12-18, 14:59, Nick Fan wrote: > > Add API to get voltage for multiple supplies from opp table > > And who needs to use this new API ? It would be better to add the user in the > same series to make sure this really gets used. This new

Re: [PATCH] opp: Add API for getting voltage from supplies

2018-12-04 Thread Viresh Kumar
On 04-12-18, 14:59, Nick Fan wrote: > Add API to get voltage for multiple supplies from opp table And who needs to use this new API ? It would be better to add the user in the same series to make sure this really gets used. > Signed-off-by: Nick Fan > --- > drivers/opp/core.c | 28 +