Re: [PATCH] pci: Disable slot presence detection around bus reset

2013-04-29 Thread Alex Williamson
On Fri, 2013-04-26 at 13:49 -0600, Bjorn Helgaas wrote: > On Wed, Apr 24, 2013 at 3:33 PM, Alex Williamson > wrote: > > On Thu, 2013-02-14 at 20:53 -0700, Alex Williamson wrote: > >> On Thu, 2013-02-14 at 16:47 -0700, Bjorn Helgaas wrote: > >> > On Thu, Feb 14, 2013 at 11:37 AM, Alex Williamson >

Re: [PATCH] pci: Disable slot presence detection around bus reset

2013-04-29 Thread Alex Williamson
On Fri, 2013-04-26 at 13:49 -0600, Bjorn Helgaas wrote: On Wed, Apr 24, 2013 at 3:33 PM, Alex Williamson alex.william...@redhat.com wrote: On Thu, 2013-02-14 at 20:53 -0700, Alex Williamson wrote: On Thu, 2013-02-14 at 16:47 -0700, Bjorn Helgaas wrote: On Thu, Feb 14, 2013 at 11:37 AM,

Re: [PATCH] pci: Disable slot presence detection around bus reset

2013-04-26 Thread Bjorn Helgaas
On Wed, Apr 24, 2013 at 3:33 PM, Alex Williamson wrote: > On Thu, 2013-02-14 at 20:53 -0700, Alex Williamson wrote: >> On Thu, 2013-02-14 at 16:47 -0700, Bjorn Helgaas wrote: >> > On Thu, Feb 14, 2013 at 11:37 AM, Alex Williamson >> > wrote: >> > > A bus reset can trigger a presence detection

Re: [PATCH] pci: Disable slot presence detection around bus reset

2013-04-26 Thread Bjorn Helgaas
On Wed, Apr 24, 2013 at 3:33 PM, Alex Williamson alex.william...@redhat.com wrote: On Thu, 2013-02-14 at 20:53 -0700, Alex Williamson wrote: On Thu, 2013-02-14 at 16:47 -0700, Bjorn Helgaas wrote: On Thu, Feb 14, 2013 at 11:37 AM, Alex Williamson alex.william...@redhat.com wrote: A bus

Re: [PATCH] pci: Disable slot presence detection around bus reset

2013-04-24 Thread Alex Williamson
On Thu, 2013-02-14 at 20:53 -0700, Alex Williamson wrote: > On Thu, 2013-02-14 at 16:47 -0700, Bjorn Helgaas wrote: > > On Thu, Feb 14, 2013 at 11:37 AM, Alex Williamson > > wrote: > > > A bus reset can trigger a presence detection change and result in a > > > suprise hotplug. This is generally

Re: [PATCH] pci: Disable slot presence detection around bus reset

2013-04-24 Thread Alex Williamson
On Thu, 2013-02-14 at 20:53 -0700, Alex Williamson wrote: On Thu, 2013-02-14 at 16:47 -0700, Bjorn Helgaas wrote: On Thu, Feb 14, 2013 at 11:37 AM, Alex Williamson alex.william...@redhat.com wrote: A bus reset can trigger a presence detection change and result in a suprise hotplug.

Re: [PATCH] pci: Disable slot presence detection around bus reset

2013-02-14 Thread Alex Williamson
On Thu, 2013-02-14 at 16:47 -0700, Bjorn Helgaas wrote: > On Thu, Feb 14, 2013 at 11:37 AM, Alex Williamson > wrote: > > A bus reset can trigger a presence detection change and result in a > > suprise hotplug. This is generally not what we want to happen when > > trying to reset a device.

Re: [PATCH] pci: Disable slot presence detection around bus reset

2013-02-14 Thread Bjorn Helgaas
On Thu, Feb 14, 2013 at 11:37 AM, Alex Williamson wrote: > A bus reset can trigger a presence detection change and result in a > suprise hotplug. This is generally not what we want to happen when > trying to reset a device. Disable the presence detection control on > on bridges around bus

Re: [PATCH] pci: Disable slot presence detection around bus reset

2013-02-14 Thread Martin Mokrejs
Hi Alex, I was just going to ask you whether your patch would "explain" why pciehp has in my experience broken presence detection while acpiphp has not (on 3.7 kernel) and whether the patch will fix it. Some testing I have done in the past on 3.2 kernel and on 3.7.1, with no fixes. Maybe you

Re: [PATCH] pci: Disable slot presence detection around bus reset

2013-02-14 Thread Alex Williamson
On Thu, 2013-02-14 at 11:37 -0700, Alex Williamson wrote: > A bus reset can trigger a presence detection change and result in a > suprise hotplug. This is generally not what we want to happen when > trying to reset a device. Disable the presence detection control on > on bridges around bus

[PATCH] pci: Disable slot presence detection around bus reset

2013-02-14 Thread Alex Williamson
A bus reset can trigger a presence detection change and result in a suprise hotplug. This is generally not what we want to happen when trying to reset a device. Disable the presence detection control on on bridges around bus reset. Signed-off-by: Alex Williamson --- drivers/pci/pci.c | 29

[PATCH] pci: Disable slot presence detection around bus reset

2013-02-14 Thread Alex Williamson
A bus reset can trigger a presence detection change and result in a suprise hotplug. This is generally not what we want to happen when trying to reset a device. Disable the presence detection control on on bridges around bus reset. Signed-off-by: Alex Williamson alex.william...@redhat.com ---

Re: [PATCH] pci: Disable slot presence detection around bus reset

2013-02-14 Thread Alex Williamson
On Thu, 2013-02-14 at 11:37 -0700, Alex Williamson wrote: A bus reset can trigger a presence detection change and result in a suprise hotplug. This is generally not what we want to happen when trying to reset a device. Disable the presence detection control on on bridges around bus reset.

Re: [PATCH] pci: Disable slot presence detection around bus reset

2013-02-14 Thread Martin Mokrejs
Hi Alex, I was just going to ask you whether your patch would explain why pciehp has in my experience broken presence detection while acpiphp has not (on 3.7 kernel) and whether the patch will fix it. Some testing I have done in the past on 3.2 kernel and on 3.7.1, with no fixes. Maybe you

Re: [PATCH] pci: Disable slot presence detection around bus reset

2013-02-14 Thread Bjorn Helgaas
On Thu, Feb 14, 2013 at 11:37 AM, Alex Williamson alex.william...@redhat.com wrote: A bus reset can trigger a presence detection change and result in a suprise hotplug. This is generally not what we want to happen when trying to reset a device. Disable the presence detection control on on

Re: [PATCH] pci: Disable slot presence detection around bus reset

2013-02-14 Thread Alex Williamson
On Thu, 2013-02-14 at 16:47 -0700, Bjorn Helgaas wrote: On Thu, Feb 14, 2013 at 11:37 AM, Alex Williamson alex.william...@redhat.com wrote: A bus reset can trigger a presence detection change and result in a suprise hotplug. This is generally not what we want to happen when trying to