Re: [PATCH] pci: fix memory leak when virtio pci hotplug

2021-03-24 Thread Zhiqiang Liu
Thanks for your suggestion. I will rewrite the commit log and send the v2 patch. On 2021/3/24 2:24, Bjorn Helgaas wrote: > On Sun, Mar 21, 2021 at 11:29:30PM +0800, Zhiqiang Liu wrote: >> From: Feilong Lin >> >> Repeated hot-plugging of pci devices for a virtual >> machine driven by virtio, we

Re: [PATCH] pci: fix memory leak when virtio pci hotplug

2021-03-23 Thread Bjorn Helgaas
On Sun, Mar 21, 2021 at 11:29:30PM +0800, Zhiqiang Liu wrote: > From: Feilong Lin > > Repeated hot-plugging of pci devices for a virtual > machine driven by virtio, we found that there is a > leak in kmalloc-4k, which was confirmed as the memory > of the pci_device structure. Then we found out

Re: [PATCH] pci: fix memory leak when virtio pci hotplug

2021-03-23 Thread Zhiqiang Liu
friendly ping.. On 2021/3/22 10:43, Wu Bo wrote: > On 2021/3/21 23:29, Zhiqiang Liu wrote: >> From: Feilong Lin >> >> Repeated hot-plugging of pci devices for a virtual >> machine driven by virtio, we found that there is a >> leak in kmalloc-4k, which was confirmed as the memory >> of the

Re: [PATCH] pci: fix memory leak when virtio pci hotplug

2021-03-21 Thread Wu Bo
On 2021/3/21 23:29, Zhiqiang Liu wrote: From: Feilong Lin Repeated hot-plugging of pci devices for a virtual machine driven by virtio, we found that there is a leak in kmalloc-4k, which was confirmed as the memory of the pci_device structure. Then we found out that it was missing pci_dev_put()

[PATCH] pci: fix memory leak when virtio pci hotplug

2021-03-21 Thread Zhiqiang Liu
From: Feilong Lin Repeated hot-plugging of pci devices for a virtual machine driven by virtio, we found that there is a leak in kmalloc-4k, which was confirmed as the memory of the pci_device structure. Then we found out that it was missing pci_dev_put() after pci_get_slot() in enable_slot() of