Re: [PATCH] pcmcia: cm4040 remove KERN_INFO as it is not at start of printk message

[Harald Welte]

Hi Colin,

the fix is obviously correct, but still for a matter of the record:

Acked-by: Harald Welte 

-- 
- Harald Welte    http://laforge.gnumonks.org/

"Privacy in residential applications is a desirable marketing option."
  (ETSI EN 300 175-7 Ch. A6)

Re: [PATCH] pcmcia: cm4040 remove KERN_INFO as it is not at start of printk message

[Harald Welte]

Hi Colin,

the fix is obviously correct, but still for a matter of the record:

Acked-by: Harald Welte 

-- 
- Harald Weltehttp://laforge.gnumonks.org/

"Privacy in residential applications is a desirable marketing option."
  (ETSI EN 300 175-7 Ch. A6)

[PATCH] pcmcia: cm4040 remove KERN_INFO as it is not at start of printk message

[Colin King]

From: Colin Ian King 

The debug is being printed using DEBUGP which prepends the string
with and so the KERN_INFO text should not be included.  Also remove the
MODULE_NAME to keep this consistent with other DEBUGP debug messages.

Signed-off-by: Colin Ian King 
---
 drivers/char/pcmcia/cm4040_cs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/pcmcia/cm4040_cs.c b/drivers/char/pcmcia/cm4040_cs.c
index fc061f7..4a606f1 100644
--- a/drivers/char/pcmcia/cm4040_cs.c
+++ b/drivers/char/pcmcia/cm4040_cs.c
@@ -506,7 +506,7 @@ static void cm4040_reader_release(struct pcmcia_device 
*link)
 
DEBUGP(3, dev, "-> cm4040_reader_release\n");
while (link->open) {
-   DEBUGP(3, dev, KERN_INFO MODULE_NAME ": delaying release "
+   DEBUGP(3, dev, "delaying release "
   "until process has terminated\n");
wait_event(dev->devq, (link->open == 0));
}
-- 
2.8.1

[PATCH] pcmcia: cm4040 remove KERN_INFO as it is not at start of printk message

[Colin King]

From: Colin Ian King 

The debug is being printed using DEBUGP which prepends the string
with and so the KERN_INFO text should not be included.  Also remove the
MODULE_NAME to keep this consistent with other DEBUGP debug messages.

Signed-off-by: Colin Ian King 
---
 drivers/char/pcmcia/cm4040_cs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/pcmcia/cm4040_cs.c b/drivers/char/pcmcia/cm4040_cs.c
index fc061f7..4a606f1 100644
--- a/drivers/char/pcmcia/cm4040_cs.c
+++ b/drivers/char/pcmcia/cm4040_cs.c
@@ -506,7 +506,7 @@ static void cm4040_reader_release(struct pcmcia_device 
*link)
 
DEBUGP(3, dev, "-> cm4040_reader_release\n");
while (link->open) {
-   DEBUGP(3, dev, KERN_INFO MODULE_NAME ": delaying release "
+   DEBUGP(3, dev, "delaying release "
   "until process has terminated\n");
wait_event(dev->devq, (link->open == 0));
}
-- 
2.8.1