Re: [PATCH] pcmcia: pd6729: fix error return code in pd6729_pci_probe()

2013-06-09 Thread Andy Shevchenko
On Fri, Jun 7, 2013 at 5:16 AM, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. What about to move the driver to pcim_*/devm_* functions? -- With Best Regards, Andy Shevchenko -- To

Re: [PATCH] pcmcia: pd6729: fix error return code in pd6729_pci_probe()

2013-06-09 Thread Andy Shevchenko
On Fri, Jun 7, 2013 at 5:16 AM, Wei Yongjun weiyj...@gmail.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. What about to move the driver to pcim_*/devm_* functions?

[PATCH] pcmcia: pd6729: fix error return code in pd6729_pci_probe()

2013-06-06 Thread Wei Yongjun
From: Wei Yongjun Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/pcmcia/pd6729.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pcmcia/pd6729.c b/drivers/pcmcia/pd6729.c

[PATCH] pcmcia: pd6729: fix error return code in pd6729_pci_probe()

2013-06-06 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/pcmcia/pd6729.c | 2 ++ 1 file changed, 2 insertions(+) diff