Re: [PATCH] perf, tools: Fix sorting for 64bit entries

2013-10-01 Thread Arnaldo Carvalho de Melo
Em Fri, Sep 27, 2013 at 04:39:24PM -0700, Andi Kleen escreveu: > From: Andi Kleen > > Some of the node comparisons in hist.c dropped the upper > 32bit by using an int variable to store the compare > result. This broke various 64bit fields, causing > incorrect collapsing (found for the TSX

Re: [PATCH] perf, tools: Fix sorting for 64bit entries

2013-10-01 Thread Arnaldo Carvalho de Melo
Em Fri, Sep 27, 2013 at 04:39:24PM -0700, Andi Kleen escreveu: From: Andi Kleen a...@linux.intel.com Some of the node comparisons in hist.c dropped the upper 32bit by using an int variable to store the compare result. This broke various 64bit fields, causing incorrect collapsing (found for

Re: [PATCH] perf, tools: Fix sorting for 64bit entries

2013-09-30 Thread Namhyung Kim
Hi Andi, On Fri, 27 Sep 2013 16:39:24 -0700, Andi Kleen wrote: > From: Andi Kleen > > Some of the node comparisons in hist.c dropped the upper > 32bit by using an int variable to store the compare > result. This broke various 64bit fields, causing > incorrect collapsing (found for the TSX

Re: [PATCH] perf, tools: Fix sorting for 64bit entries

2013-09-30 Thread Namhyung Kim
Hi Andi, On Fri, 27 Sep 2013 16:39:24 -0700, Andi Kleen wrote: From: Andi Kleen a...@linux.intel.com Some of the node comparisons in hist.c dropped the upper 32bit by using an int variable to store the compare result. This broke various 64bit fields, causing incorrect collapsing (found for

[PATCH] perf, tools: Fix sorting for 64bit entries

2013-09-27 Thread Andi Kleen
From: Andi Kleen Some of the node comparisons in hist.c dropped the upper 32bit by using an int variable to store the compare result. This broke various 64bit fields, causing incorrect collapsing (found for the TSX transaction field) Just use int64_t always. Signed-off-by: Andi Kleen ---

[PATCH] perf, tools: Fix sorting for 64bit entries

2013-09-27 Thread Andi Kleen
From: Andi Kleen a...@linux.intel.com Some of the node comparisons in hist.c dropped the upper 32bit by using an int variable to store the compare result. This broke various 64bit fields, causing incorrect collapsing (found for the TSX transaction field) Just use int64_t always. Signed-off-by: