Re: [PATCH] perf/core: Fix hung issue on perf stat command during cpu hotplug

2020-10-08 Thread Peter Zijlstra
On Thu, Oct 08, 2020 at 05:55:35PM +0530, kajoljain wrote: > > > On 8/27/20 12:17 PM, Kajol Jain wrote: > > Commit 2ed6edd33a21 ("perf: Add cond_resched() to task_function_call()") > > added assignment of ret value as -EAGAIN in case function > > call to 'smp_call_function_single' fails. > > For

Re: [PATCH] perf/core: Fix hung issue on perf stat command during cpu hotplug

2020-10-08 Thread kajoljain
On 8/27/20 12:17 PM, Kajol Jain wrote: > Commit 2ed6edd33a21 ("perf: Add cond_resched() to task_function_call()") > added assignment of ret value as -EAGAIN in case function > call to 'smp_call_function_single' fails. > For non-zero ret value, it did > 'ret = !ret ? data.ret : -EAGAIN;', which

Re: [PATCH] perf/core: Fix hung issue on perf stat command during cpu hotplug

2020-09-02 Thread kajoljain
On 9/2/20 8:35 PM, Arnaldo Carvalho de Melo wrote: > Em Thu, Aug 27, 2020 at 12:17:32PM +0530, Kajol Jain escreveu: >> Commit 2ed6edd33a21 ("perf: Add cond_resched() to task_function_call()") >> added assignment of ret value as -EAGAIN in case function >> call to 'smp_call_function_single'

Re: [PATCH] perf/core: Fix hung issue on perf stat command during cpu hotplug

2020-09-02 Thread Arnaldo Carvalho de Melo
Em Thu, Aug 27, 2020 at 12:17:32PM +0530, Kajol Jain escreveu: > Commit 2ed6edd33a21 ("perf: Add cond_resched() to task_function_call()") > added assignment of ret value as -EAGAIN in case function > call to 'smp_call_function_single' fails. > For non-zero ret value, it did > 'ret = !ret ?

[PATCH] perf/core: Fix hung issue on perf stat command during cpu hotplug

2020-08-27 Thread Kajol Jain
Commit 2ed6edd33a21 ("perf: Add cond_resched() to task_function_call()") added assignment of ret value as -EAGAIN in case function call to 'smp_call_function_single' fails. For non-zero ret value, it did 'ret = !ret ? data.ret : -EAGAIN;', which always assign -EAGAIN to ret and make second if