Re: [PATCH] perf/core: fix perf_proc_update_handler() bug

2019-01-18 Thread Arnaldo Carvalho de Melo
Em Thu, Jan 17, 2019 at 01:03:20PM -0800, Stephane Eranian escreveu: > On Thu, Jan 10, 2019 at 5:17 PM Stephane Eranian wrote: > > > > The perf_proc_update_handler() handles > > /proc/sys/kernel/perf_event_max_sample_rate > > syctl variable. When the PMU IRQ handler timing monitoring is

Re: [PATCH] perf/core: fix perf_proc_update_handler() bug

2019-01-18 Thread Jiri Olsa
On Thu, Jan 10, 2019 at 05:17:16PM -0800, Stephane Eranian wrote: > The perf_proc_update_handler() handles > /proc/sys/kernel/perf_event_max_sample_rate > syctl variable. When the PMU IRQ handler timing monitoring is disabled, i.e, > when /proc/sys/kernel/perf_cpu_time_max_percent is equal to 0

Re: [PATCH] perf/core: fix perf_proc_update_handler() bug

2019-01-17 Thread Andi Kleen
On Thu, Jan 17, 2019 at 01:03:20PM -0800, Stephane Eranian wrote: > On Thu, Jan 10, 2019 at 5:17 PM Stephane Eranian wrote: > > > > The perf_proc_update_handler() handles > > /proc/sys/kernel/perf_event_max_sample_rate > > syctl variable. When the PMU IRQ handler timing monitoring is disabled,

Re: [PATCH] perf/core: fix perf_proc_update_handler() bug

2019-01-17 Thread Stephane Eranian
On Thu, Jan 10, 2019 at 5:17 PM Stephane Eranian wrote: > > The perf_proc_update_handler() handles > /proc/sys/kernel/perf_event_max_sample_rate > syctl variable. When the PMU IRQ handler timing monitoring is disabled, i.e, > when /proc/sys/kernel/perf_cpu_time_max_percent is equal to 0 or 100,

[PATCH] perf/core: fix perf_proc_update_handler() bug

2019-01-10 Thread Stephane Eranian
The perf_proc_update_handler() handles /proc/sys/kernel/perf_event_max_sample_rate syctl variable. When the PMU IRQ handler timing monitoring is disabled, i.e, when /proc/sys/kernel/perf_cpu_time_max_percent is equal to 0 or 100, then no modification to sysctl_perf_event_sample_rate is allowed