Re: [PATCH] perf: Avoid missing macros FALSE, TRUE outside ui/gtk/

2013-07-08 Thread Greg Price
On Mon, Jul 08, 2013 at 03:10:52PM +0200, Jiri Olsa wrote: > On Mon, Jul 08, 2013 at 08:11:50AM -0400, Greg Price wrote: > > We use these macros in a few files in ui/gtk/ and they work fine > > because GTK includes GLib which defines them, but here in util/ > > they break the build, at least on my

Re: [PATCH] perf: Avoid missing macros FALSE, TRUE outside ui/gtk/

2013-07-08 Thread Jiri Olsa
On Mon, Jul 08, 2013 at 08:11:50AM -0400, Greg Price wrote: > We use these macros in a few files in ui/gtk/ and they work fine > because GTK includes GLib which defines them, but here in util/ > they break the build, at least on my machine. So stick to 0 and 1. and here's another one, pick at

[PATCH] perf: Avoid missing macros FALSE, TRUE outside ui/gtk/

2013-07-08 Thread Greg Price
We use these macros in a few files in ui/gtk/ and they work fine because GTK includes GLib which defines them, but here in util/ they break the build, at least on my machine. So stick to 0 and 1. Cc: Arnaldo Carvalho de Melo Cc: Waiman Long Cc: Jiri Olsa Signed-off-by: Greg Price --- This

[PATCH] perf: Avoid missing macros FALSE, TRUE outside ui/gtk/

2013-07-08 Thread Greg Price
We use these macros in a few files in ui/gtk/ and they work fine because GTK includes GLib which defines them, but here in util/ they break the build, at least on my machine. So stick to 0 and 1. Cc: Arnaldo Carvalho de Melo a...@redhat.com Cc: Waiman Long waiman.l...@hp.com Cc: Jiri Olsa

Re: [PATCH] perf: Avoid missing macros FALSE, TRUE outside ui/gtk/

2013-07-08 Thread Jiri Olsa
On Mon, Jul 08, 2013 at 08:11:50AM -0400, Greg Price wrote: We use these macros in a few files in ui/gtk/ and they work fine because GTK includes GLib which defines them, but here in util/ they break the build, at least on my machine. So stick to 0 and 1. and here's another one, pick at your

Re: [PATCH] perf: Avoid missing macros FALSE, TRUE outside ui/gtk/

2013-07-08 Thread Greg Price
On Mon, Jul 08, 2013 at 03:10:52PM +0200, Jiri Olsa wrote: On Mon, Jul 08, 2013 at 08:11:50AM -0400, Greg Price wrote: We use these macros in a few files in ui/gtk/ and they work fine because GTK includes GLib which defines them, but here in util/ they break the build, at least on my