Re: [PATCH] perf: Support for Openembedded/Yocto -dbg packages

2013-10-01 Thread Ingo Molnar
* Namhyung Kim wrote: > Hi Ingo and Arnaldo, > > On Wed, 18 Sep 2013 15:29:03 +0200, Ingo Molnar wrote: > > * Arnaldo Carvalho de Melo wrote: > > > >> Em Wed, Sep 18, 2013 at 12:18:01PM +0200, Peter Zijlstra escreveu: > >> > On Wed, Sep 18, 2013 at 12:02:12PM +0200, Ricardo Ribalda Delgado wro

Re: [PATCH] perf: Support for Openembedded/Yocto -dbg packages

2013-10-01 Thread Namhyung Kim
Hi Ingo and Arnaldo, On Wed, 18 Sep 2013 15:29:03 +0200, Ingo Molnar wrote: > * Arnaldo Carvalho de Melo wrote: > >> Em Wed, Sep 18, 2013 at 12:18:01PM +0200, Peter Zijlstra escreveu: >> > On Wed, Sep 18, 2013 at 12:02:12PM +0200, Ricardo Ribalda Delgado wrote: >> > > Perhaps this is even more cl

Re: [PATCH] perf: Support for Openembedded/Yocto -dbg packages

2013-09-18 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 18, 2013 at 03:29:03PM +0200, Ingo Molnar escreveu: > * Arnaldo Carvalho de Melo wrote: > > Em Wed, Sep 18, 2013 at 12:18:01PM +0200, Peter Zijlstra escreveu: > > > len += snprintf(str + len, size - len, ...); > > > len += snprintf(str + len, size - len, ...); > > And avoid snprintf l

Re: [PATCH] perf: Support for Openembedded/Yocto -dbg packages

2013-09-18 Thread Ricardo Ribalda Delgado
Hello Ingo Arnaldo and Peter I have just posted v3, Thanks for your comments! On Wed, Sep 18, 2013 at 3:29 PM, Ingo Molnar wrote: > > * Arnaldo Carvalho de Melo wrote: > >> Em Wed, Sep 18, 2013 at 12:18:01PM +0200, Peter Zijlstra escreveu: >> > On Wed, Sep 18, 2013 at 12:02:12PM +0200, Ricardo

Re: [PATCH] perf: Support for Openembedded/Yocto -dbg packages

2013-09-18 Thread Ingo Molnar
* Arnaldo Carvalho de Melo wrote: > Em Wed, Sep 18, 2013 at 12:18:01PM +0200, Peter Zijlstra escreveu: > > On Wed, Sep 18, 2013 at 12:02:12PM +0200, Ricardo Ribalda Delgado wrote: > > > Perhaps this is even more clear than v2: > > > > len = snprintf(file, size, "%s", symbol_conf.symfs); > > > s

Re: [PATCH] perf: Support for Openembedded/Yocto -dbg packages

2013-09-18 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 18, 2013 at 12:18:01PM +0200, Peter Zijlstra escreveu: > On Wed, Sep 18, 2013 at 12:02:12PM +0200, Ricardo Ribalda Delgado wrote: > > Perhaps this is even more clear than v2: > > len = snprintf(file, size, "%s", symbol_conf.symfs); > > size -= len; > > file += len; > > len = snprintf(f

Re: [PATCH] perf: Support for Openembedded/Yocto -dbg packages

2013-09-18 Thread Peter Zijlstra
On Wed, Sep 18, 2013 at 12:02:12PM +0200, Ricardo Ribalda Delgado wrote: > Hello again Ingo: > > Perhaps this is even more clear than v2: > > len = snprintf(file, size, "%s", symbol_conf.symfs); > size -= len; > file += len; > len = snprintf(file, MIN(size,(last_slash - dso->long_name) + 2), > "%

Re: [PATCH] perf: Support for Openembedded/Yocto -dbg packages

2013-09-18 Thread Ricardo Ribalda Delgado
Hello again Ingo: Perhaps this is even more clear than v2: len = snprintf(file, size, "%s", symbol_conf.symfs); size -= len; file += len; len = snprintf(file, MIN(size,(last_slash - dso->long_name) + 2), "%s", dso->long_name); size -= len; file += len; len = snprintf(file, size, ".debug%s", las

Re: [PATCH] perf: Support for Openembedded/Yocto -dbg packages

2013-09-18 Thread Ricardo Ribalda Delgado
Hello Ingo Incredible how many code style rules I can break in 20 lines of code :). I have just uploaded v2 Thanks for your comments. On Wed, Sep 18, 2013 at 11:24 AM, Ingo Molnar wrote: > > * Ricardo Ribalda Delgado wrote: > >> On OpenEmbedded the symbol files are located under a .debug folde

Re: [PATCH] perf: Support for Openembedded/Yocto -dbg packages

2013-09-18 Thread Ingo Molnar
* Ricardo Ribalda Delgado wrote: > On OpenEmbedded the symbol files are located under a .debug folder on > the same folder as the binary file. > > This patch adds support for such files. It would be nice to cite before/after perf report output, to see how this improved things and to see the o

[PATCH] perf: Support for Openembedded/Yocto -dbg packages

2013-09-18 Thread Ricardo Ribalda Delgado
On OpenEmbedded the symbol files are located under a .debug folder on the same folder as the binary file. This patch adds support for such files. Signed-off-by: Ricardo Ribalda Delgado --- tools/perf/util/dso.c| 16 tools/perf/util/dso.h| 1 + tools/perf/util/symbol.c