Re: [PATCH] perf: detect when perf.data file not closed out properly

2013-05-09 Thread David Ahern
On 5/9/13 3:32 AM, Ingo Molnar wrote: * David Ahern wrote: + pr_err("data size is 0. " + "Was the record command properly terminated?\n"); Btw., a small stylistic request: please put user-visible strings into a single line - even if it technically turns in

Re: [PATCH] perf: detect when perf.data file not closed out properly

2013-05-09 Thread Ingo Molnar
* David Ahern wrote: > + pr_err("data size is 0. " > +"Was the record command properly terminated?\n"); Btw., a small stylistic request: please put user-visible strings into a single line - even if it technically turns into an overlong line. pr_

[PATCH] perf: detect when perf.data file not closed out properly

2013-05-08 Thread David Ahern
perf-record updates the header in the perf.data file at termination. Without this update perf-report (and other processing builtins) cannot properly read events from the file -- the algorithm in __perf_session__process_events depends on the data_size which is read from the file header and that func