Re: [PATCH] perf annotate: fix parsing aarch64 branch instructions after objdump update

2018-08-27 Thread Arnaldo Carvalho de Melo
Em Thu, Aug 23, 2018 at 07:10:47PM -0500, Kim Phillips escreveu: > Starting with binutils 2.28, aarch64 objdump adds comments to the > disassembly output to show the alternative names of a condition code [1]. > > It is assumed that commas in objdump comments could occur in other arches > now or

Re: [PATCH] perf annotate: fix parsing aarch64 branch instructions after objdump update

2018-08-27 Thread Arnaldo Carvalho de Melo
Em Thu, Aug 23, 2018 at 07:10:47PM -0500, Kim Phillips escreveu: > Starting with binutils 2.28, aarch64 objdump adds comments to the > disassembly output to show the alternative names of a condition code [1]. > > It is assumed that commas in objdump comments could occur in other arches > now or

Re: [PATCH] perf annotate: fix parsing aarch64 branch instructions after objdump update

2018-08-24 Thread Kim Phillips
On Fri, 24 Aug 2018 09:59:22 +0200 Thomas-Mich Richter wrote: > On 08/24/2018 02:10 AM, Kim Phillips wrote: > > Tested no difference in output for sample x86_64, power arch perf.data > > files. > > Tested, no difference in output on s390. Just to let you know. Thanks! An official Tested-by:

Re: [PATCH] perf annotate: fix parsing aarch64 branch instructions after objdump update

2018-08-24 Thread Kim Phillips
On Fri, 24 Aug 2018 09:59:22 +0200 Thomas-Mich Richter wrote: > On 08/24/2018 02:10 AM, Kim Phillips wrote: > > Tested no difference in output for sample x86_64, power arch perf.data > > files. > > Tested, no difference in output on s390. Just to let you know. Thanks! An official Tested-by:

Re: [PATCH] perf annotate: fix parsing aarch64 branch instructions after objdump update

2018-08-24 Thread Thomas-Mich Richter
On 08/24/2018 02:10 AM, Kim Phillips wrote: > Starting with binutils 2.28, aarch64 objdump adds comments to the > disassembly output to show the alternative names of a condition code [1]. > > It is assumed that commas in objdump comments could occur in other arches > now or in the future, so this

Re: [PATCH] perf annotate: fix parsing aarch64 branch instructions after objdump update

2018-08-24 Thread Thomas-Mich Richter
On 08/24/2018 02:10 AM, Kim Phillips wrote: > Starting with binutils 2.28, aarch64 objdump adds comments to the > disassembly output to show the alternative names of a condition code [1]. > > It is assumed that commas in objdump comments could occur in other arches > now or in the future, so this

[PATCH] perf annotate: fix parsing aarch64 branch instructions after objdump update

2018-08-23 Thread Kim Phillips
Starting with binutils 2.28, aarch64 objdump adds comments to the disassembly output to show the alternative names of a condition code [1]. It is assumed that commas in objdump comments could occur in other arches now or in the future, so this fix is arch-independent. The fix could have been

[PATCH] perf annotate: fix parsing aarch64 branch instructions after objdump update

2018-08-23 Thread Kim Phillips
Starting with binutils 2.28, aarch64 objdump adds comments to the disassembly output to show the alternative names of a condition code [1]. It is assumed that commas in objdump comments could occur in other arches now or in the future, so this fix is arch-independent. The fix could have been