Re: [PATCH] perf hists browser: Fix segfault when all entries be filtered

2015-03-10 Thread Namhyung Kim
Hi, On Tue, Mar 10, 2015 at 11:38:59AM +0800, He Kuang wrote: > ping.. > On 2015/3/4 12:13, He Kuang wrote: > >When all perf report entries be filtered, the result of > >hists__filter_entries() can be NULL, check the result before processing. In that case, browser->nr_entries should be zero

Re: [PATCH] perf hists browser: Fix segfault when all entries be filtered

2015-03-10 Thread Namhyung Kim
Hi, On Tue, Mar 10, 2015 at 11:38:59AM +0800, He Kuang wrote: ping.. On 2015/3/4 12:13, He Kuang wrote: When all perf report entries be filtered, the result of hists__filter_entries() can be NULL, check the result before processing. In that case, browser-nr_entries should be zero IMHO. But

Re: [PATCH] perf hists browser: Fix segfault when all entries be filtered

2015-03-09 Thread He Kuang
ping.. On 2015/3/4 12:13, He Kuang wrote: When all perf report entries be filtered, the result of hists__filter_entries() can be NULL, check the result before processing. Miss this checking will cause segmentation fault like this: $ perf report (filter all entries and left nothing, then

Re: [PATCH] perf hists browser: Fix segfault when all entries be filtered

2015-03-09 Thread He Kuang
ping.. On 2015/3/4 12:13, He Kuang wrote: When all perf report entries be filtered, the result of hists__filter_entries() can be NULL, check the result before processing. Miss this checking will cause segmentation fault like this: $ perf report (filter all entries and left nothing, then

[PATCH] perf hists browser: Fix segfault when all entries be filtered

2015-03-03 Thread He Kuang
When all perf report entries be filtered, the result of hists__filter_entries() can be NULL, check the result before processing. Miss this checking will cause segmentation fault like this: $ perf report (filter all entries and left nothing, then zoom in/out) perf: Segmentation fault

[PATCH] perf hists browser: Fix segfault when all entries be filtered

2015-03-03 Thread He Kuang
When all perf report entries be filtered, the result of hists__filter_entries() can be NULL, check the result before processing. Miss this checking will cause segmentation fault like this: $ perf report (filter all entries and left nothing, then zoom in/out) perf: Segmentation fault