Re: [PATCH] perf record: Add missing perf_hpp__init for pipe-mode
On 13.09.12 13:14:30, Namhyung Kim wrote:
> From: Namhyung Kim
>
> The perf_hpp__init() function was only called from setup_browser() so
> that the pipe-mode missed the initialization thus didn't respond to
> related options. Fix it.
>
> Reported-by: Robert Richter
> Signed-off-by: Namhyung Kim
> ---
> tools/perf/builtin-report.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
This patch fixes it.
Thanks,
-Robert
>
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index 97b2e6300f4c..279155a47d1c 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -689,8 +689,10 @@ int cmd_report(int argc, const char **argv, const char
> *prefix __maybe_unused)
>
> if (strcmp(report.input_name, "-") != 0)
> setup_browser(true);
> - else
> + else {
> use_browser = 0;
> + perf_hpp__init(false, false);
> + }
>
> /*
>* Only in the newt browser we are doing integrated annotation,
> --
> 1.7.11.4
>
>
--
Advanced Micro Devices, Inc.
Operating System Research Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] perf record: Add missing perf_hpp__init for pipe-mode
On 13.09.12 13:14:30, Namhyung Kim wrote:
From: Namhyung Kim namhyung@lge.com
The perf_hpp__init() function was only called from setup_browser() so
that the pipe-mode missed the initialization thus didn't respond to
related options. Fix it.
Reported-by: Robert Richter robert.rich...@amd.com
Signed-off-by: Namhyung Kim namhy...@kernel.org
---
tools/perf/builtin-report.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
This patch fixes it.
Thanks,
-Robert
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 97b2e6300f4c..279155a47d1c 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -689,8 +689,10 @@ int cmd_report(int argc, const char **argv, const char
*prefix __maybe_unused)
if (strcmp(report.input_name, -) != 0)
setup_browser(true);
- else
+ else {
use_browser = 0;
+ perf_hpp__init(false, false);
+ }
/*
* Only in the newt browser we are doing integrated annotation,
--
1.7.11.4
--
Advanced Micro Devices, Inc.
Operating System Research Center
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] perf record: Add missing perf_hpp__init for pipe-mode
Oops, please do s/record/report/ on the subject line, sorry! ;-) Also I don't see the issue on the other users of the setup_browser() - i.e. perf annotate and perf top - since they call it unconditionally. Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] perf record: Add missing perf_hpp__init for pipe-mode
From: Namhyung Kim
The perf_hpp__init() function was only called from setup_browser() so
that the pipe-mode missed the initialization thus didn't respond to
related options. Fix it.
Reported-by: Robert Richter
Signed-off-by: Namhyung Kim
---
tools/perf/builtin-report.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 97b2e6300f4c..279155a47d1c 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -689,8 +689,10 @@ int cmd_report(int argc, const char **argv, const char
*prefix __maybe_unused)
if (strcmp(report.input_name, "-") != 0)
setup_browser(true);
- else
+ else {
use_browser = 0;
+ perf_hpp__init(false, false);
+ }
/*
* Only in the newt browser we are doing integrated annotation,
--
1.7.11.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] perf record: Add missing perf_hpp__init for pipe-mode
From: Namhyung Kim namhyung@lge.com
The perf_hpp__init() function was only called from setup_browser() so
that the pipe-mode missed the initialization thus didn't respond to
related options. Fix it.
Reported-by: Robert Richter robert.rich...@amd.com
Signed-off-by: Namhyung Kim namhy...@kernel.org
---
tools/perf/builtin-report.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 97b2e6300f4c..279155a47d1c 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -689,8 +689,10 @@ int cmd_report(int argc, const char **argv, const char
*prefix __maybe_unused)
if (strcmp(report.input_name, -) != 0)
setup_browser(true);
- else
+ else {
use_browser = 0;
+ perf_hpp__init(false, false);
+ }
/*
* Only in the newt browser we are doing integrated annotation,
--
1.7.11.4
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] perf record: Add missing perf_hpp__init for pipe-mode
Oops, please do s/record/report/ on the subject line, sorry! ;-) Also I don't see the issue on the other users of the setup_browser() - i.e. perf annotate and perf top - since they call it unconditionally. Thanks, Namhyung -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
