Re: [PATCH] perf tools: Don't write to evsel if parser doesn't collect evsel

2015-09-02 Thread pi3orama
发自我的 iPhone > 在 2015年9月2日，下午10:43，Arnaldo Carvalho de Melo 写道： > > Em Wed, Sep 02, 2015 at 10:04:21PM +0800, pi3orama escreveu: >> 发自我的 iPhone >>> 在 2015年9月2日，下午9:55，Arnaldo Carvalho de Melo 写道： >>> Em Wed, Sep 02, 2015 at 08:05:54PM +0800, pi3orama escreveu: 发自我的 iPhone > 在

Re: [PATCH] perf tools: Don't write to evsel if parser doesn't collect evsel

2015-09-02 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 02, 2015 at 10:04:21PM +0800, pi3orama escreveu: > 发自我的 iPhone > > 在 2015年9月2日，下午9:55，Arnaldo Carvalho de Melo 写道： > > Em Wed, Sep 02, 2015 at 08:05:54PM +0800, pi3orama escreveu: > >> 发自我的 iPhone > >>> 在 2015年9月2日，下午7:54，Jiri Olsa 写道： > > On Wed, Sep 02, 2015 at 02:53:58PM

Re: [PATCH] perf tools: Don't write to evsel if parser doesn't collect evsel

2015-09-02 Thread pi3orama
发自我的 iPhone > 在 2015年9月2日，下午9:55，Arnaldo Carvalho de Melo 写道： > > Em Wed, Sep 02, 2015 at 08:05:54PM +0800, pi3orama escreveu: >> 发自我的 iPhone >>> 在 2015年9月2日，下午7:54，Jiri Olsa 写道： > On Wed, Sep 02, 2015 at 02:53:58PM +0800, Wangnan (F) wrote: > @@ -1252,7 +1262,13 @@

Re: [PATCH] perf tools: Don't write to evsel if parser doesn't collect evsel

2015-09-02 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 02, 2015 at 08:05:54PM +0800, pi3orama escreveu: > 发自我的 iPhone > > 在 2015年9月2日，下午7:54，Jiri Olsa 写道： > >> On Wed, Sep 02, 2015 at 02:53:58PM +0800, Wangnan (F) wrote: > >>> @@ -1252,7 +1262,13 @@ foreach_evsel_in_last_glob(struct perf_evlist > >>> *evlist, > >>>struct perf_evsel

Re: [PATCH] perf tools: Don't write to evsel if parser doesn't collect evsel

2015-09-02 Thread Jiri Olsa
On Wed, Sep 02, 2015 at 08:05:54PM +0800, pi3orama wrote: SNIP > >>>perf_evlist__splice_list_tail(evlist, , entries); > >>>evlist->nr_groups += data.nr_groups; > >>> -last = perf_evlist__last(evlist); > >>> -last->cmdline_group_boundary = true; > >>>return

Re: [PATCH] perf tools: Don't write to evsel if parser doesn't collect evsel

2015-09-02 Thread pi3orama
发自我的 iPhone > 在 2015年9月2日，下午7:54，Jiri Olsa 写道： > >> On Wed, Sep 02, 2015 at 02:53:58PM +0800, Wangnan (F) wrote: >> Sorry, forget to CC kernel mailing list... >> >>> On 2015/9/2 14:49, Wang Nan wrote: >>> If parse_events__scanner() collects no entry, perf_evlist__last(evlist) >>> is invalid.

Re: [PATCH] perf tools: Don't write to evsel if parser doesn't collect evsel

2015-09-02 Thread Jiri Olsa
On Wed, Sep 02, 2015 at 02:53:58PM +0800, Wangnan (F) wrote: > Sorry, forget to CC kernel mailing list... > > On 2015/9/2 14:49, Wang Nan wrote: > >If parse_events__scanner() collects no entry, perf_evlist__last(evlist) > >is invalid. > > > >Although it shouldn't happen at this point, before

RE: [PATCH] perf tools: Don't write to evsel if parser doesn't collect evsel

2015-09-02 Thread 平松雅巳 / HIRAMATU，MASAMI
> From: Wangnan (F) [mailto:wangn...@huawei.com] > > Sorry, forget to CC kernel mailing list... > > On 2015/9/2 14:49, Wang Nan wrote: > > If parse_events__scanner() collects no entry, perf_evlist__last(evlist) > > is invalid. > > > > Although it shouldn't happen at this point, before calling >

Re: [PATCH] perf tools: Don't write to evsel if parser doesn't collect evsel

2015-09-02 Thread Wangnan (F)
Sorry, forget to CC kernel mailing list... On 2015/9/2 14:49, Wang Nan wrote: If parse_events__scanner() collects no entry, perf_evlist__last(evlist) is invalid. Although it shouldn't happen at this point, before calling perf_evlist__last(), we should ensure the list is not empty for safety

Re: [PATCH] perf tools: Don't write to evsel if parser doesn't collect evsel

2015-09-02 Thread Wangnan (F)
Sorry, forget to CC kernel mailing list... On 2015/9/2 14:49, Wang Nan wrote: If parse_events__scanner() collects no entry, perf_evlist__last(evlist) is invalid. Although it shouldn't happen at this point, before calling perf_evlist__last(), we should ensure the list is not empty for safety

Re: [PATCH] perf tools: Don't write to evsel if parser doesn't collect evsel

2015-09-02 Thread pi3orama
发自我的 iPhone > 在 2015年9月2日，下午10:43，Arnaldo Carvalho de Melo 写道： > > Em Wed, Sep 02, 2015 at 10:04:21PM +0800, pi3orama escreveu: >> 发自我的 iPhone >>> 在 2015年9月2日，下午9:55，Arnaldo Carvalho de Melo 写道： >>> Em Wed, Sep 02, 2015 at 08:05:54PM +0800, pi3orama

Re: [PATCH] perf tools: Don't write to evsel if parser doesn't collect evsel

2015-09-02 Thread Jiri Olsa
On Wed, Sep 02, 2015 at 02:53:58PM +0800, Wangnan (F) wrote: > Sorry, forget to CC kernel mailing list... > > On 2015/9/2 14:49, Wang Nan wrote: > >If parse_events__scanner() collects no entry, perf_evlist__last(evlist) > >is invalid. > > > >Although it shouldn't happen at this point, before

Re: [PATCH] perf tools: Don't write to evsel if parser doesn't collect evsel

2015-09-02 Thread pi3orama
发自我的 iPhone > 在 2015年9月2日，下午7:54，Jiri Olsa 写道： > >> On Wed, Sep 02, 2015 at 02:53:58PM +0800, Wangnan (F) wrote: >> Sorry, forget to CC kernel mailing list... >> >>> On 2015/9/2 14:49, Wang Nan wrote: >>> If parse_events__scanner() collects no entry,

Re: [PATCH] perf tools: Don't write to evsel if parser doesn't collect evsel

2015-09-02 Thread pi3orama
发自我的 iPhone > 在 2015年9月2日，下午9:55，Arnaldo Carvalho de Melo 写道： > > Em Wed, Sep 02, 2015 at 08:05:54PM +0800, pi3orama escreveu: >> 发自我的 iPhone >>> 在 2015年9月2日，下午7:54，Jiri Olsa 写道： > On Wed, Sep 02, 2015 at 02:53:58PM +0800, Wangnan (F) wrote: > @@

Re: [PATCH] perf tools: Don't write to evsel if parser doesn't collect evsel

2015-09-02 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 02, 2015 at 08:05:54PM +0800, pi3orama escreveu: > 发自我的 iPhone > > 在 2015年9月2日，下午7:54，Jiri Olsa 写道： > >> On Wed, Sep 02, 2015 at 02:53:58PM +0800, Wangnan (F) wrote: > >>> @@ -1252,7 +1262,13 @@ foreach_evsel_in_last_glob(struct perf_evlist > >>> *evlist, > >>>

RE: [PATCH] perf tools: Don't write to evsel if parser doesn't collect evsel

2015-09-02 Thread 平松雅巳 / HIRAMATU，MASAMI
> From: Wangnan (F) [mailto:wangn...@huawei.com] > > Sorry, forget to CC kernel mailing list... > > On 2015/9/2 14:49, Wang Nan wrote: > > If parse_events__scanner() collects no entry, perf_evlist__last(evlist) > > is invalid. > > > > Although it shouldn't happen at this point, before calling >

Re: [PATCH] perf tools: Don't write to evsel if parser doesn't collect evsel

2015-09-02 Thread Jiri Olsa
On Wed, Sep 02, 2015 at 08:05:54PM +0800, pi3orama wrote: SNIP > >>>perf_evlist__splice_list_tail(evlist, , entries); > >>>evlist->nr_groups += data.nr_groups; > >>> -last = perf_evlist__last(evlist); > >>> -last->cmdline_group_boundary = true; > >>>return

Re: [PATCH] perf tools: Don't write to evsel if parser doesn't collect evsel

2015-09-02 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 02, 2015 at 10:04:21PM +0800, pi3orama escreveu: > 发自我的 iPhone > > 在 2015年9月2日，下午9:55，Arnaldo Carvalho de Melo 写道： > > Em Wed, Sep 02, 2015 at 08:05:54PM +0800, pi3orama escreveu: > >> 发自我的 iPhone > >>> 在 2015年9月2日，下午7:54，Jiri Olsa 写道： > > On