Re: [PATCH] perf tools: Speed up the perf build time by simplifying the perf --version string generation

2012-10-30 Thread Ingo Molnar
* Arnaldo Carvalho de Melo wrote: > Em Tue, Oct 30, 2012 at 10:48:52AM +0100, Ingo Molnar escreveu: > > > > * Ingo Molnar wrote: > > > > > Does -l work? > > > > > > Alternatively, please replace: > > > > > > git tag --list "v[0-9].[0-9]*" | tail -1 > > > > > > with: > > > > > > git

Re: [PATCH] perf tools: Speed up the perf build time by simplifying the perf --version string generation

2012-10-30 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 30, 2012 at 10:48:52AM +0100, Ingo Molnar escreveu: > > * Ingo Molnar wrote: > > > Does -l work? > > > > Alternatively, please replace: > > > > git tag --list "v[0-9].[0-9]*" | tail -1 > > > > with: > > > > git tag | tail -1 | grep -E "v[0-9].[0-9]*" > > > > which is just

Re: [PATCH] perf tools: Speed up the perf build time by simplifying the perf --version string generation

2012-10-30 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 30, 2012 at 10:43:38AM +0100, Ingo Molnar escreveu: > > * Arnaldo Carvalho de Melo wrote: > > > Em Tue, Oct 30, 2012 at 09:46:00AM +0100, Ingo Molnar escreveu: > > > +++ b/tools/perf/util/PERF-VERSION-GEN > > > @@ -12,7 +12,7 @@ LF=' > > > # First check if there is a .git to get

Re: [PATCH] perf tools: Speed up the perf build time by simplifying the perf --version string generation

2012-10-30 Thread Ingo Molnar
* Ingo Molnar wrote: > Does -l work? > > Alternatively, please replace: > > git tag --list "v[0-9].[0-9]*" | tail -1 > > with: > > git tag | tail -1 | grep -E "v[0-9].[0-9]*" > > which is just as fast. make that: git tag 2>/dev/null | tail -1 | grep -E "v[0-9].[0-9]*" this will

Re: [PATCH] perf tools: Speed up the perf build time by simplifying the perf --version string generation

2012-10-30 Thread Ingo Molnar
* Arnaldo Carvalho de Melo wrote: > Em Tue, Oct 30, 2012 at 09:46:00AM +0100, Ingo Molnar escreveu: > > +++ b/tools/perf/util/PERF-VERSION-GEN > > @@ -12,7 +12,7 @@ LF=' > > # First check if there is a .git to get the version from git describe > > # otherwise try to get the version from the

Re: [PATCH] perf tools: Speed up the perf build time by simplifying the perf --version string generation

2012-10-30 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 30, 2012 at 09:46:00AM +0100, Ingo Molnar escreveu: > +++ b/tools/perf/util/PERF-VERSION-GEN > @@ -12,7 +12,7 @@ LF=' > # First check if there is a .git to get the version from git describe > # otherwise try to get the version from the kernel makefile > if test -d ../../.git -o -f

[PATCH] perf tools: Speed up the perf build time by simplifying the perf --version string generation

2012-10-30 Thread Ingo Molnar
* Ingo Molnar wrote: > Btw., there's another thing that would be nice in addition to > simplifying the PERF-VERSION-GEN script: [...] Here's a stab at that. -> Building perf is pretty slow on trees that have a lot of commits relative to the nearest Git tag. This slowness

[PATCH] perf tools: Speed up the perf build time by simplifying the perf --version string generation

2012-10-30 Thread Ingo Molnar
* Ingo Molnar mi...@kernel.org wrote: Btw., there's another thing that would be nice in addition to simplifying the PERF-VERSION-GEN script: [...] Here's a stab at that. - Building perf is pretty slow on trees that have a lot of commits relative to the nearest Git tag.

Re: [PATCH] perf tools: Speed up the perf build time by simplifying the perf --version string generation

2012-10-30 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 30, 2012 at 09:46:00AM +0100, Ingo Molnar escreveu: +++ b/tools/perf/util/PERF-VERSION-GEN @@ -12,7 +12,7 @@ LF=' # First check if there is a .git to get the version from git describe # otherwise try to get the version from the kernel makefile if test -d ../../.git -o -f

Re: [PATCH] perf tools: Speed up the perf build time by simplifying the perf --version string generation

2012-10-30 Thread Ingo Molnar
* Arnaldo Carvalho de Melo a...@infradead.org wrote: Em Tue, Oct 30, 2012 at 09:46:00AM +0100, Ingo Molnar escreveu: +++ b/tools/perf/util/PERF-VERSION-GEN @@ -12,7 +12,7 @@ LF=' # First check if there is a .git to get the version from git describe # otherwise try to get the version

Re: [PATCH] perf tools: Speed up the perf build time by simplifying the perf --version string generation

2012-10-30 Thread Ingo Molnar
* Ingo Molnar mi...@kernel.org wrote: Does -l work? Alternatively, please replace: git tag --list v[0-9].[0-9]* | tail -1 with: git tag | tail -1 | grep -E v[0-9].[0-9]* which is just as fast. make that: git tag 2/dev/null | tail -1 | grep -E v[0-9].[0-9]* this will

Re: [PATCH] perf tools: Speed up the perf build time by simplifying the perf --version string generation

2012-10-30 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 30, 2012 at 10:43:38AM +0100, Ingo Molnar escreveu: * Arnaldo Carvalho de Melo a...@infradead.org wrote: Em Tue, Oct 30, 2012 at 09:46:00AM +0100, Ingo Molnar escreveu: +++ b/tools/perf/util/PERF-VERSION-GEN @@ -12,7 +12,7 @@ LF=' # First check if there is a .git to

Re: [PATCH] perf tools: Speed up the perf build time by simplifying the perf --version string generation

2012-10-30 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 30, 2012 at 10:48:52AM +0100, Ingo Molnar escreveu: * Ingo Molnar mi...@kernel.org wrote: Does -l work? Alternatively, please replace: git tag --list v[0-9].[0-9]* | tail -1 with: git tag | tail -1 | grep -E v[0-9].[0-9]* which is just as fast.

Re: [PATCH] perf tools: Speed up the perf build time by simplifying the perf --version string generation

2012-10-30 Thread Ingo Molnar
* Arnaldo Carvalho de Melo a...@infradead.org wrote: Em Tue, Oct 30, 2012 at 10:48:52AM +0100, Ingo Molnar escreveu: * Ingo Molnar mi...@kernel.org wrote: Does -l work? Alternatively, please replace: git tag --list v[0-9].[0-9]* | tail -1 with: git tag