RE: [PATCH] pinctrl: exynos5440/samsung: Staticize pcfgs
Linus Walleij wrote: > > On Tue, Nov 27, 2012 at 3:49 PM, Axel Lin wrote: > > > I got below build error with random config if CONFIG_PINCTRL_SAMSUNG=y > && > > CONFIG_PINCTRL_EXYNOS5440=y. > > > > Fix the build error by making pcfgs static. > > > > LD drivers/pinctrl/built-in.o > > drivers/pinctrl/pinctrl-exynos5440.o: In function `.LANCHOR0': > > pinctrl-exynos5440.c:(.data+0x54): multiple definition of `pcfgs' > > drivers/pinctrl/pinctrl-samsung.o:pinctrl-samsung.c:(.data+0x54): first > defined here > > make[2]: *** [drivers/pinctrl/built-in.o] Error 1 > > make[1]: *** [drivers/pinctrl] Error 2 > > make: *** [drivers] Error 2 > > > > Signed-off-by: Axel Lin > > I'm not handling the Samsung drivers for this merge window. > Samsung guys, can you please pick up this patch? > > Acked-by: Linus Walleij > Applied, thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] pinctrl: exynos5440/samsung: Staticize pcfgs
Linus Walleij wrote: On Tue, Nov 27, 2012 at 3:49 PM, Axel Lin axel@ingics.com wrote: I got below build error with random config if CONFIG_PINCTRL_SAMSUNG=y CONFIG_PINCTRL_EXYNOS5440=y. Fix the build error by making pcfgs static. LD drivers/pinctrl/built-in.o drivers/pinctrl/pinctrl-exynos5440.o: In function `.LANCHOR0': pinctrl-exynos5440.c:(.data+0x54): multiple definition of `pcfgs' drivers/pinctrl/pinctrl-samsung.o:pinctrl-samsung.c:(.data+0x54): first defined here make[2]: *** [drivers/pinctrl/built-in.o] Error 1 make[1]: *** [drivers/pinctrl] Error 2 make: *** [drivers] Error 2 Signed-off-by: Axel Lin axel@ingics.com I'm not handling the Samsung drivers for this merge window. Samsung guys, can you please pick up this patch? Acked-by: Linus Walleij linus.wall...@linaro.org Applied, thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] pinctrl: exynos5440/samsung: Staticize pcfgs
Thomas Abraham wrote: > > On 27 November 2012 20:19, Axel Lin wrote: > > I got below build error with random config if CONFIG_PINCTRL_SAMSUNG=y > && > > CONFIG_PINCTRL_EXYNOS5440=y. > > > > Fix the build error by making pcfgs static. > > > > LD drivers/pinctrl/built-in.o > > drivers/pinctrl/pinctrl-exynos5440.o: In function `.LANCHOR0': > > pinctrl-exynos5440.c:(.data+0x54): multiple definition of `pcfgs' > > drivers/pinctrl/pinctrl-samsung.o:pinctrl-samsung.c:(.data+0x54): first > defined here > > make[2]: *** [drivers/pinctrl/built-in.o] Error 1 > > make[1]: *** [drivers/pinctrl] Error 2 > > make: *** [drivers] Error 2 > > > > Signed-off-by: Axel Lin > > Acked-by: Thomas Abraham > > Dear Mr. Kim, > > Could you please consider this patch in your next pull request for fixes. > Sure, I will. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] pinctrl: exynos5440/samsung: Staticize pcfgs
On 27 November 2012 20:19, Axel Lin wrote: > I got below build error with random config if CONFIG_PINCTRL_SAMSUNG=y && > CONFIG_PINCTRL_EXYNOS5440=y. > > Fix the build error by making pcfgs static. > > LD drivers/pinctrl/built-in.o > drivers/pinctrl/pinctrl-exynos5440.o: In function `.LANCHOR0': > pinctrl-exynos5440.c:(.data+0x54): multiple definition of `pcfgs' > drivers/pinctrl/pinctrl-samsung.o:pinctrl-samsung.c:(.data+0x54): first > defined here > make[2]: *** [drivers/pinctrl/built-in.o] Error 1 > make[1]: *** [drivers/pinctrl] Error 2 > make: *** [drivers] Error 2 > > Signed-off-by: Axel Lin Acked-by: Thomas Abraham Dear Mr. Kim, Could you please consider this patch in your next pull request for fixes. Thanks, Thomas. [...] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] pinctrl: exynos5440/samsung: Staticize pcfgs
On 27 November 2012 20:19, Axel Lin axel@ingics.com wrote: I got below build error with random config if CONFIG_PINCTRL_SAMSUNG=y CONFIG_PINCTRL_EXYNOS5440=y. Fix the build error by making pcfgs static. LD drivers/pinctrl/built-in.o drivers/pinctrl/pinctrl-exynos5440.o: In function `.LANCHOR0': pinctrl-exynos5440.c:(.data+0x54): multiple definition of `pcfgs' drivers/pinctrl/pinctrl-samsung.o:pinctrl-samsung.c:(.data+0x54): first defined here make[2]: *** [drivers/pinctrl/built-in.o] Error 1 make[1]: *** [drivers/pinctrl] Error 2 make: *** [drivers] Error 2 Signed-off-by: Axel Lin axel@ingics.com Acked-by: Thomas Abraham thomas.abra...@linaro.org Dear Mr. Kim, Could you please consider this patch in your next pull request for fixes. Thanks, Thomas. [...] -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] pinctrl: exynos5440/samsung: Staticize pcfgs
Thomas Abraham wrote: On 27 November 2012 20:19, Axel Lin axel@ingics.com wrote: I got below build error with random config if CONFIG_PINCTRL_SAMSUNG=y CONFIG_PINCTRL_EXYNOS5440=y. Fix the build error by making pcfgs static. LD drivers/pinctrl/built-in.o drivers/pinctrl/pinctrl-exynos5440.o: In function `.LANCHOR0': pinctrl-exynos5440.c:(.data+0x54): multiple definition of `pcfgs' drivers/pinctrl/pinctrl-samsung.o:pinctrl-samsung.c:(.data+0x54): first defined here make[2]: *** [drivers/pinctrl/built-in.o] Error 1 make[1]: *** [drivers/pinctrl] Error 2 make: *** [drivers] Error 2 Signed-off-by: Axel Lin axel@ingics.com Acked-by: Thomas Abraham thomas.abra...@linaro.org Dear Mr. Kim, Could you please consider this patch in your next pull request for fixes. Sure, I will. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] pinctrl: exynos5440/samsung: Staticize pcfgs
On Tue, Nov 27, 2012 at 3:49 PM, Axel Lin wrote: > I got below build error with random config if CONFIG_PINCTRL_SAMSUNG=y && > CONFIG_PINCTRL_EXYNOS5440=y. > > Fix the build error by making pcfgs static. > > LD drivers/pinctrl/built-in.o > drivers/pinctrl/pinctrl-exynos5440.o: In function `.LANCHOR0': > pinctrl-exynos5440.c:(.data+0x54): multiple definition of `pcfgs' > drivers/pinctrl/pinctrl-samsung.o:pinctrl-samsung.c:(.data+0x54): first > defined here > make[2]: *** [drivers/pinctrl/built-in.o] Error 1 > make[1]: *** [drivers/pinctrl] Error 2 > make: *** [drivers] Error 2 > > Signed-off-by: Axel Lin I'm not handling the Samsung drivers for this merge window. Samsung guys, can you please pick up this patch? Acked-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] pinctrl: exynos5440/samsung: Staticize pcfgs
On Tue, Nov 27, 2012 at 3:49 PM, Axel Lin axel@ingics.com wrote: I got below build error with random config if CONFIG_PINCTRL_SAMSUNG=y CONFIG_PINCTRL_EXYNOS5440=y. Fix the build error by making pcfgs static. LD drivers/pinctrl/built-in.o drivers/pinctrl/pinctrl-exynos5440.o: In function `.LANCHOR0': pinctrl-exynos5440.c:(.data+0x54): multiple definition of `pcfgs' drivers/pinctrl/pinctrl-samsung.o:pinctrl-samsung.c:(.data+0x54): first defined here make[2]: *** [drivers/pinctrl/built-in.o] Error 1 make[1]: *** [drivers/pinctrl] Error 2 make: *** [drivers] Error 2 Signed-off-by: Axel Lin axel@ingics.com I'm not handling the Samsung drivers for this merge window. Samsung guys, can you please pick up this patch? Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] pinctrl: exynos5440/samsung: Staticize pcfgs
I got below build error with random config if CONFIG_PINCTRL_SAMSUNG=y &&
CONFIG_PINCTRL_EXYNOS5440=y.
Fix the build error by making pcfgs static.
LD drivers/pinctrl/built-in.o
drivers/pinctrl/pinctrl-exynos5440.o: In function `.LANCHOR0':
pinctrl-exynos5440.c:(.data+0x54): multiple definition of `pcfgs'
drivers/pinctrl/pinctrl-samsung.o:pinctrl-samsung.c:(.data+0x54): first defined
here
make[2]: *** [drivers/pinctrl/built-in.o] Error 1
make[1]: *** [drivers/pinctrl] Error 2
make: *** [drivers] Error 2
Signed-off-by: Axel Lin
---
drivers/pinctrl/pinctrl-exynos5440.c |2 +-
drivers/pinctrl/pinctrl-samsung.c|2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-exynos5440.c
b/drivers/pinctrl/pinctrl-exynos5440.c
index b8635f6..07db895 100644
--- a/drivers/pinctrl/pinctrl-exynos5440.c
+++ b/drivers/pinctrl/pinctrl-exynos5440.c
@@ -117,7 +117,7 @@ struct exynos5440_pinctrl_priv_data {
};
/* list of all possible config options supported */
-struct pin_config {
+static struct pin_config {
char*prop_cfg;
unsigned intcfg_type;
} pcfgs[] = {
diff --git a/drivers/pinctrl/pinctrl-samsung.c
b/drivers/pinctrl/pinctrl-samsung.c
index 8f31b65..864fed8 100644
--- a/drivers/pinctrl/pinctrl-samsung.c
+++ b/drivers/pinctrl/pinctrl-samsung.c
@@ -37,7 +37,7 @@
#define FSUFFIX_LENsizeof(FUNCTION_SUFFIX)
/* list of all possible config options supported */
-struct pin_config {
+static struct pin_config {
char*prop_cfg;
unsigned intcfg_type;
} pcfgs[] = {
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] pinctrl: exynos5440/samsung: Staticize pcfgs
I got below build error with random config if CONFIG_PINCTRL_SAMSUNG=y
CONFIG_PINCTRL_EXYNOS5440=y.
Fix the build error by making pcfgs static.
LD drivers/pinctrl/built-in.o
drivers/pinctrl/pinctrl-exynos5440.o: In function `.LANCHOR0':
pinctrl-exynos5440.c:(.data+0x54): multiple definition of `pcfgs'
drivers/pinctrl/pinctrl-samsung.o:pinctrl-samsung.c:(.data+0x54): first defined
here
make[2]: *** [drivers/pinctrl/built-in.o] Error 1
make[1]: *** [drivers/pinctrl] Error 2
make: *** [drivers] Error 2
Signed-off-by: Axel Lin axel@ingics.com
---
drivers/pinctrl/pinctrl-exynos5440.c |2 +-
drivers/pinctrl/pinctrl-samsung.c|2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-exynos5440.c
b/drivers/pinctrl/pinctrl-exynos5440.c
index b8635f6..07db895 100644
--- a/drivers/pinctrl/pinctrl-exynos5440.c
+++ b/drivers/pinctrl/pinctrl-exynos5440.c
@@ -117,7 +117,7 @@ struct exynos5440_pinctrl_priv_data {
};
/* list of all possible config options supported */
-struct pin_config {
+static struct pin_config {
char*prop_cfg;
unsigned intcfg_type;
} pcfgs[] = {
diff --git a/drivers/pinctrl/pinctrl-samsung.c
b/drivers/pinctrl/pinctrl-samsung.c
index 8f31b65..864fed8 100644
--- a/drivers/pinctrl/pinctrl-samsung.c
+++ b/drivers/pinctrl/pinctrl-samsung.c
@@ -37,7 +37,7 @@
#define FSUFFIX_LENsizeof(FUNCTION_SUFFIX)
/* list of all possible config options supported */
-struct pin_config {
+static struct pin_config {
char*prop_cfg;
unsigned intcfg_type;
} pcfgs[] = {
--
1.7.9.5
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
