Re: [PATCH] pktcdvd : add kobject_put when kobject register fails

2007-12-04 Thread Dave Young
On Tue, Dec 04, 2007 at 10:05:24AM +0200, Pekka J Enberg wrote: > Hi Dave, > > On Tue, 4 Dec 2007, Dave Young wrote: > > the kobject reference is get in kobject_init, and then kobject_add, if > > kobject_add fail, it will only cleanup the reference got by itsself. > > > > This topic is discussed

Re: [PATCH] pktcdvd : add kobject_put when kobject register fails

2007-12-04 Thread Pekka J Enberg
Hi Dave, On Tue, 4 Dec 2007, Dave Young wrote: > the kobject reference is get in kobject_init, and then kobject_add, if > kobject_add fail, it will only cleanup the reference got by itsself. > > This topic is discussed in: > http://lkml.org/lkml/2007/11/30/9 Ok, thanks! Please the explanation

Re: [PATCH] pktcdvd : add kobject_put when kobject register fails

2007-12-04 Thread Dave Young
On Dec 4, 2007 3:45 PM, Pekka Enberg <[EMAIL PROTECTED]> wrote: > Hi Dave, > > On Dec 4, 2007 3:31 AM, Dave Young <[EMAIL PROTECTED]> wrote: > > Kobject_put should be called when kobject register functioin fails, so the > > the kobj ref count touch zero and then the proper cleanup routines will be

Re: [PATCH] pktcdvd : add kobject_put when kobject register fails

2007-12-04 Thread Dave Young
On Dec 4, 2007 3:45 PM, Pekka Enberg [EMAIL PROTECTED] wrote: Hi Dave, On Dec 4, 2007 3:31 AM, Dave Young [EMAIL PROTECTED] wrote: Kobject_put should be called when kobject register functioin fails, so the the kobj ref count touch zero and then the proper cleanup routines will be called.

Re: [PATCH] pktcdvd : add kobject_put when kobject register fails

2007-12-04 Thread Pekka J Enberg
Hi Dave, On Tue, 4 Dec 2007, Dave Young wrote: the kobject reference is get in kobject_init, and then kobject_add, if kobject_add fail, it will only cleanup the reference got by itsself. This topic is discussed in: http://lkml.org/lkml/2007/11/30/9 Ok, thanks! Please the explanation to the

Re: [PATCH] pktcdvd : add kobject_put when kobject register fails

2007-12-04 Thread Dave Young
On Tue, Dec 04, 2007 at 10:05:24AM +0200, Pekka J Enberg wrote: Hi Dave, On Tue, 4 Dec 2007, Dave Young wrote: the kobject reference is get in kobject_init, and then kobject_add, if kobject_add fail, it will only cleanup the reference got by itsself. This topic is discussed in:

Re: [PATCH] pktcdvd : add kobject_put when kobject register fails

2007-12-03 Thread Pekka Enberg
Hi Dave, On Dec 4, 2007 3:31 AM, Dave Young <[EMAIL PROTECTED]> wrote: > Kobject_put should be called when kobject register functioin fails, so the > the kobj ref count touch zero and then the proper cleanup routines will be > called. [snip] > diff -upr linux/drivers/block/pktcdvd.c

[PATCH] pktcdvd : add kobject_put when kobject register fails

2007-12-03 Thread Dave Young
Kobject_put should be called when kobject register functioin fails, so the the kobj ref count touch zero and then the proper cleanup routines will be called. Signed-off-by: Dave Young <[EMAIL PROTECTED]> --- drivers/block/pktcdvd.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[PATCH] pktcdvd : add kobject_put when kobject register fails

2007-12-03 Thread Dave Young
Kobject_put should be called when kobject register functioin fails, so the the kobj ref count touch zero and then the proper cleanup routines will be called. Signed-off-by: Dave Young [EMAIL PROTECTED] --- drivers/block/pktcdvd.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

Re: [PATCH] pktcdvd : add kobject_put when kobject register fails

2007-12-03 Thread Pekka Enberg
Hi Dave, On Dec 4, 2007 3:31 AM, Dave Young [EMAIL PROTECTED] wrote: Kobject_put should be called when kobject register functioin fails, so the the kobj ref count touch zero and then the proper cleanup routines will be called. [snip] diff -upr linux/drivers/block/pktcdvd.c