Re: [PATCH] platform/chrome: Update cros_ec sysfs attributes on sensors discovery

2021-04-03 Thread kernel test robot
Hi Gwendal, Thank you for the patch! Yet something to improve: [auto build test ERROR on chrome-platform-linux/for-next] [also build test ERROR on linux/master linus/master v5.12-rc5 next-20210401] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch,

Re: [PATCH] platform/chrome: Update cros_ec sysfs attributes on sensors discovery

2021-04-03 Thread Greg KH
On Fri, Apr 02, 2021 at 11:20:31PM -0700, Gwendal Grignou wrote: > When cros_ec_sysfs probe is called before cros_ec_sensorhub probe > routine, the |kb_wake_angle| attribute will not be displayed, even if > there are two accelerometers in the chromebook. > > Call sysfs_update_group() when

Re: [PATCH] platform/chrome: Update cros_ec sysfs attributes on sensors discovery

2021-04-03 Thread kernel test robot
Hi Gwendal, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on chrome-platform-linux/for-next] [also build test WARNING on linux/master linus/master v5.12-rc5 next-20210401] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH] platform/chrome: Update cros_ec sysfs attributes on sensors discovery

2021-04-03 Thread kernel test robot
Hi Gwendal, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on chrome-platform-linux/for-next] [also build test WARNING on linux/master linus/master v5.12-rc5 next-20210401] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

[PATCH] platform/chrome: Update cros_ec sysfs attributes on sensors discovery

2021-04-03 Thread Gwendal Grignou
When cros_ec_sysfs probe is called before cros_ec_sensorhub probe routine, the |kb_wake_angle| attribute will not be displayed, even if there are two accelerometers in the chromebook. Call sysfs_update_group() when accelerometers are enumerated if the cros_ec sysfs attributes group has already