Re: [PATCH] platform/x86: acer-wmi: Mark expected switch fall-throughs

2019-06-29 Thread Andy Shevchenko
On Thu, May 9, 2019 at 4:48 AM Gustavo A. R. Silva wrote: > Commit 5c742b45dd5fbbb6cf74d3378341704f4b23c5e8 mentions that "This was fixed > in acer_acpi some time ago, but I forgot to port the patch over to acer-wmi > when it was merged." Notice that this driver (acer-wmi) is based on the >

Re: [PATCH] platform/x86: acer-wmi: Mark expected switch fall-throughs

2019-05-08 Thread Gustavo A. R. Silva
Darren, Please, see my comments below... On 5/8/19 6:06 PM, Darren Hart wrote: > On Wed, May 08, 2019 at 11:49:34AM -0500, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch >> cases where we are expecting to fall through. >> >> This patch fixes the

Re: [PATCH] platform/x86: acer-wmi: Mark expected switch fall-throughs

2019-05-08 Thread Darren Hart
On Wed, May 08, 2019 at 11:49:34AM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/platform/x86/acer-wmi.c: In function ‘set_u32’: >

[PATCH] platform/x86: acer-wmi: Mark expected switch fall-throughs

2019-05-08 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warnings: drivers/platform/x86/acer-wmi.c: In function ‘set_u32’: drivers/platform/x86/acer-wmi.c:1378:33: warning: this statement may fall through

Re: [PATCH] platform/x86: acer-wmi: mark expected switch fall-throughs

2018-07-06 Thread Darren Hart
On Thu, Jul 05, 2018 at 03:42:21PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Warning level 2 was used: -Wimplicit-fallthrough=2 > > Signed-off-by: Gustavo A. R. Silva > --- >

Re: [PATCH] platform/x86: acer-wmi: mark expected switch fall-throughs

2018-07-06 Thread Darren Hart
On Thu, Jul 05, 2018 at 03:42:21PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Warning level 2 was used: -Wimplicit-fallthrough=2 > > Signed-off-by: Gustavo A. R. Silva > --- >

[PATCH] platform/x86: acer-wmi: mark expected switch fall-throughs

2018-07-05 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Warning level 2 was used: -Wimplicit-fallthrough=2 Signed-off-by: Gustavo A. R. Silva --- drivers/platform/x86/acer-wmi.c | 4 1 file changed, 4 insertions(+) diff --git

[PATCH] platform/x86: acer-wmi: mark expected switch fall-throughs

2018-07-05 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Warning level 2 was used: -Wimplicit-fallthrough=2 Signed-off-by: Gustavo A. R. Silva --- drivers/platform/x86/acer-wmi.c | 4 1 file changed, 4 insertions(+) diff --git