Re: [PATCH] platform/x86: panasonic-laptop: add support to mute and hardware optical switch

[Andy Shevchenko]

On Fri, Mar 16, 2018 at 1:09 PM, Harald Welte  wrote:
> Hi Kenneth,
>
> thanks for your fix.  I'm not currently using any Panasonic Laptop devices
> anymore (After the CF-R series was discontinued), so I'm not able to properly
> maintain this driver anymore.
>
> However, your changes look sound to me (aside from that we don't use C++ style
> comments in kernel source code), hence:
>
> Acked-by: Harald Welte 

I'm not sure I ever seen the original patch. Patchwork also misses it.


-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] platform/x86: panasonic-laptop: add support to mute and hardware optical switch

[Andy Shevchenko]

On Fri, Mar 16, 2018 at 1:09 PM, Harald Welte  wrote:
> Hi Kenneth,
>
> thanks for your fix.  I'm not currently using any Panasonic Laptop devices
> anymore (After the CF-R series was discontinued), so I'm not able to properly
> maintain this driver anymore.
>
> However, your changes look sound to me (aside from that we don't use C++ style
> comments in kernel source code), hence:
>
> Acked-by: Harald Welte 

I'm not sure I ever seen the original patch. Patchwork also misses it.


-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] platform/x86: panasonic-laptop: add support to mute and hardware optical switch

[Harald Welte]

Hi Kenneth,

thanks for your fix.  I'm not currently using any Panasonic Laptop devices
anymore (After the CF-R series was discontinued), so I'm not able to properly
maintain this driver anymore.

However, your changes look sound to me (aside from that we don't use C++ style
comments in kernel source code), hence:

Acked-by: Harald Welte 

-- 
- Harald Welte    http://laforge.gnumonks.org/

"Privacy in residential applications is a desirable marketing option."
  (ETSI EN 300 175-7 Ch. A6)

Re: [PATCH] platform/x86: panasonic-laptop: add support to mute and hardware optical switch

[Harald Welte]

Hi Kenneth,

thanks for your fix.  I'm not currently using any Panasonic Laptop devices
anymore (After the CF-R series was discontinued), so I'm not able to properly
maintain this driver anymore.

However, your changes look sound to me (aside from that we don't use C++ style
comments in kernel source code), hence:

Acked-by: Harald Welte 

-- 
- Harald Weltehttp://laforge.gnumonks.org/

"Privacy in residential applications is a desirable marketing option."
  (ETSI EN 300 175-7 Ch. A6)