Re: [PATCH] platform/x86: peaq-wmi: Add DMI check before binding to the WMI interface

2017-10-08 Thread Andy Shevchenko
On Thu, Oct 5, 2017 at 9:04 PM, Hans de Goede wrote: > It seems that the WMI GUID used by the PEAQ 2-in-1 WMI hotkeys is not > as unique as a GUID should be and is used on some other devices too. > > This is causing spurious key-press reports on these other devices. > > This

Re: [PATCH] platform/x86: peaq-wmi: Add DMI check before binding to the WMI interface

2017-10-08 Thread Andy Shevchenko
On Thu, Oct 5, 2017 at 9:04 PM, Hans de Goede wrote: > It seems that the WMI GUID used by the PEAQ 2-in-1 WMI hotkeys is not > as unique as a GUID should be and is used on some other devices too. > > This is causing spurious key-press reports on these other devices. > > This commits adds a DMI

Re: [PATCH] platform/x86: peaq-wmi: Add DMI check before binding to the WMI interface

2017-10-06 Thread Darren Hart
On Thu, Oct 05, 2017 at 09:19:23PM +0300, Andy Shevchenko wrote: > On Thu, Oct 5, 2017 at 9:04 PM, Hans de Goede wrote: > > It seems that the WMI GUID used by the PEAQ 2-in-1 WMI hotkeys is not > > as unique as a GUID should be and is used on some other devices too. > > > >

Re: [PATCH] platform/x86: peaq-wmi: Add DMI check before binding to the WMI interface

2017-10-06 Thread Darren Hart
On Thu, Oct 05, 2017 at 09:19:23PM +0300, Andy Shevchenko wrote: > On Thu, Oct 5, 2017 at 9:04 PM, Hans de Goede wrote: > > It seems that the WMI GUID used by the PEAQ 2-in-1 WMI hotkeys is not > > as unique as a GUID should be and is used on some other devices too. > > > > This is causing

Re: [PATCH] platform/x86: peaq-wmi: Add DMI check before binding to the WMI interface

2017-10-05 Thread Andy Shevchenko
On Thu, Oct 5, 2017 at 9:04 PM, Hans de Goede wrote: > It seems that the WMI GUID used by the PEAQ 2-in-1 WMI hotkeys is not > as unique as a GUID should be and is used on some other devices too. > > This is causing spurious key-press reports on these other devices. > > This

Re: [PATCH] platform/x86: peaq-wmi: Add DMI check before binding to the WMI interface

2017-10-05 Thread Andy Shevchenko
On Thu, Oct 5, 2017 at 9:04 PM, Hans de Goede wrote: > It seems that the WMI GUID used by the PEAQ 2-in-1 WMI hotkeys is not > as unique as a GUID should be and is used on some other devices too. > > This is causing spurious key-press reports on these other devices. > > This commits adds a DMI

Re: [PATCH] platform/x86: peaq-wmi: Add DMI check before binding to the WMI interface

2017-10-05 Thread Andy Shevchenko
On Thu, Oct 5, 2017 at 9:04 PM, Hans de Goede wrote: > On 05-10-17 19:59, Andy Shevchenko wrote: >> On Thu, Oct 5, 2017 at 5:27 PM, Hans de Goede wrote: >> ... however, the patch can't be dropped. >> >> Either me, or you in v2 need to revert it. Tell me

Re: [PATCH] platform/x86: peaq-wmi: Add DMI check before binding to the WMI interface

2017-10-05 Thread Andy Shevchenko
On Thu, Oct 5, 2017 at 9:04 PM, Hans de Goede wrote: > On 05-10-17 19:59, Andy Shevchenko wrote: >> On Thu, Oct 5, 2017 at 5:27 PM, Hans de Goede wrote: >> ... however, the patch can't be dropped. >> >> Either me, or you in v2 need to revert it. Tell me what you prefer here. > Isn't the whole

[PATCH] platform/x86: peaq-wmi: Add DMI check before binding to the WMI interface

2017-10-05 Thread Hans de Goede
It seems that the WMI GUID used by the PEAQ 2-in-1 WMI hotkeys is not as unique as a GUID should be and is used on some other devices too. This is causing spurious key-press reports on these other devices. This commits adds a DMI check to the PEAQ 2-in-1 WMI hotkeys driver to ensure that it is

[PATCH] platform/x86: peaq-wmi: Add DMI check before binding to the WMI interface

2017-10-05 Thread Hans de Goede
It seems that the WMI GUID used by the PEAQ 2-in-1 WMI hotkeys is not as unique as a GUID should be and is used on some other devices too. This is causing spurious key-press reports on these other devices. This commits adds a DMI check to the PEAQ 2-in-1 WMI hotkeys driver to ensure that it is

Re: [PATCH] platform/x86: peaq-wmi: Add DMI check before binding to the WMI interface

2017-10-05 Thread Hans de Goede
Hi, On 05-10-17 19:59, Andy Shevchenko wrote: On Thu, Oct 5, 2017 at 5:27 PM, Hans de Goede wrote: Hi, On 05-10-17 16:23, Andy Shevchenko wrote: On Thu, Oct 5, 2017 at 5:20 PM, Hans de Goede wrote: It seems that the WMI GUID used by the PEAQ

Re: [PATCH] platform/x86: peaq-wmi: Add DMI check before binding to the WMI interface

2017-10-05 Thread Hans de Goede
Hi, On 05-10-17 19:59, Andy Shevchenko wrote: On Thu, Oct 5, 2017 at 5:27 PM, Hans de Goede wrote: Hi, On 05-10-17 16:23, Andy Shevchenko wrote: On Thu, Oct 5, 2017 at 5:20 PM, Hans de Goede wrote: It seems that the WMI GUID used by the PEAQ 2-in-1 WMI hotkeys is not as unique as a GUID

Re: [PATCH] platform/x86: peaq-wmi: Add DMI check before binding to the WMI interface

2017-10-05 Thread Andy Shevchenko
On Thu, Oct 5, 2017 at 5:27 PM, Hans de Goede wrote: > Hi, > > On 05-10-17 16:23, Andy Shevchenko wrote: >> >> On Thu, Oct 5, 2017 at 5:20 PM, Hans de Goede wrote: >>> >>> It seems that the WMI GUID used by the PEAQ 2-in-1 WMI hotkeys is not >>> as

Re: [PATCH] platform/x86: peaq-wmi: Add DMI check before binding to the WMI interface

2017-10-05 Thread Andy Shevchenko
On Thu, Oct 5, 2017 at 5:27 PM, Hans de Goede wrote: > Hi, > > On 05-10-17 16:23, Andy Shevchenko wrote: >> >> On Thu, Oct 5, 2017 at 5:20 PM, Hans de Goede wrote: >>> >>> It seems that the WMI GUID used by the PEAQ 2-in-1 WMI hotkeys is not >>> as unique as a GUID should be and is used on some

Re: [PATCH] platform/x86: peaq-wmi: Add DMI check before binding to the WMI interface

2017-10-05 Thread Hans de Goede
Hi, On 05-10-17 16:23, Andy Shevchenko wrote: On Thu, Oct 5, 2017 at 5:20 PM, Hans de Goede wrote: It seems that the WMI GUID used by the PEAQ 2-in-1 WMI hotkeys is not as unique as a GUID should be and is used on some other devices too. This is causing spurious

Re: [PATCH] platform/x86: peaq-wmi: Add DMI check before binding to the WMI interface

2017-10-05 Thread Hans de Goede
Hi, On 05-10-17 16:23, Andy Shevchenko wrote: On Thu, Oct 5, 2017 at 5:20 PM, Hans de Goede wrote: It seems that the WMI GUID used by the PEAQ 2-in-1 WMI hotkeys is not as unique as a GUID should be and is used on some other devices too. This is causing spurious key-press reports on these

Re: [PATCH] platform/x86: peaq-wmi: Add DMI check before binding to the WMI interface

2017-10-05 Thread Andy Shevchenko
On Thu, Oct 5, 2017 at 5:20 PM, Hans de Goede wrote: > It seems that the WMI GUID used by the PEAQ 2-in-1 WMI hotkeys is not > as unique as a GUID should be and is used on some other devices too. > > This is causing spurious key-press reports on these other devices. > > This

Re: [PATCH] platform/x86: peaq-wmi: Add DMI check before binding to the WMI interface

2017-10-05 Thread Andy Shevchenko
On Thu, Oct 5, 2017 at 5:20 PM, Hans de Goede wrote: > It seems that the WMI GUID used by the PEAQ 2-in-1 WMI hotkeys is not > as unique as a GUID should be and is used on some other devices too. > > This is causing spurious key-press reports on these other devices. > > This commits adds a DMI

[PATCH] platform/x86: peaq-wmi: Add DMI check before binding to the WMI interface

2017-10-05 Thread Hans de Goede
It seems that the WMI GUID used by the PEAQ 2-in-1 WMI hotkeys is not as unique as a GUID should be and is used on some other devices too. This is causing spurious key-press reports on these other devices. This commits adds a DMI check to the PEAQ 2-in-1 WMI hotkeys driver to ensure that it is

[PATCH] platform/x86: peaq-wmi: Add DMI check before binding to the WMI interface

2017-10-05 Thread Hans de Goede
It seems that the WMI GUID used by the PEAQ 2-in-1 WMI hotkeys is not as unique as a GUID should be and is used on some other devices too. This is causing spurious key-press reports on these other devices. This commits adds a DMI check to the PEAQ 2-in-1 WMI hotkeys driver to ensure that it is