On Sun, Jul 08, 2018 at 03:56:17AM +0900, Mattia Dongili wrote:
> On Fri, Jul 06, 2018 at 04:24:27PM -0700, Darren Hart wrote:
> > On Thu, Jul 05, 2018 at 03:47:03PM -0500, Gustavo A. R. Silva wrote:
> > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> > > where we are
On Sun, Jul 08, 2018 at 03:56:17AM +0900, Mattia Dongili wrote:
> On Fri, Jul 06, 2018 at 04:24:27PM -0700, Darren Hart wrote:
> > On Thu, Jul 05, 2018 at 03:47:03PM -0500, Gustavo A. R. Silva wrote:
> > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> > > where we are
On Fri, Jul 06, 2018 at 04:24:27PM -0700, Darren Hart wrote:
> On Thu, Jul 05, 2018 at 03:47:03PM -0500, Gustavo A. R. Silva wrote:
> > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> > where we are expecting to fall through.
> >
> > Signed-off-by: Gustavo A. R. Silva
> >
On Fri, Jul 06, 2018 at 04:24:27PM -0700, Darren Hart wrote:
> On Thu, Jul 05, 2018 at 03:47:03PM -0500, Gustavo A. R. Silva wrote:
> > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> > where we are expecting to fall through.
> >
> > Signed-off-by: Gustavo A. R. Silva
> >
On Sat, Jul 7, 2018 at 2:24 AM, Darren Hart wrote:
> return AE_CTRL_TERMINATE;
>
> Is unreachable as there are no "break" statements in the switch, and the
> default
> falls through to return AE_OK. Something doesn't seem right here.
Darren, I didn't look at the code in question,
On Sat, Jul 7, 2018 at 2:24 AM, Darren Hart wrote:
> return AE_CTRL_TERMINATE;
>
> Is unreachable as there are no "break" statements in the switch, and the
> default
> falls through to return AE_OK. Something doesn't seem right here.
Darren, I didn't look at the code in question,
On Thu, Jul 05, 2018 at 03:47:03PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva
> ---
> drivers/platform/x86/sony-laptop.c | 1 +
> 1 file changed, 1
On Thu, Jul 05, 2018 at 03:47:03PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva
> ---
> drivers/platform/x86/sony-laptop.c | 1 +
> 1 file changed, 1
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva
---
drivers/platform/x86/sony-laptop.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/sony-laptop.c
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva
---
drivers/platform/x86/sony-laptop.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/sony-laptop.c
10 matches
Mail list logo