Re: [PATCH] platform/x86: sony-laptop: Mark expected switch fall-through

2018-09-11 Thread Darren Hart
On Sun, Jul 08, 2018 at 03:56:17AM +0900, Mattia Dongili wrote: > On Fri, Jul 06, 2018 at 04:24:27PM -0700, Darren Hart wrote: > > On Thu, Jul 05, 2018 at 03:47:03PM -0500, Gustavo A. R. Silva wrote: > > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > > where we are

Re: [PATCH] platform/x86: sony-laptop: Mark expected switch fall-through

2018-09-11 Thread Darren Hart
On Sun, Jul 08, 2018 at 03:56:17AM +0900, Mattia Dongili wrote: > On Fri, Jul 06, 2018 at 04:24:27PM -0700, Darren Hart wrote: > > On Thu, Jul 05, 2018 at 03:47:03PM -0500, Gustavo A. R. Silva wrote: > > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > > where we are

Re: [PATCH] platform/x86: sony-laptop: Mark expected switch fall-through

2018-07-07 Thread Mattia Dongili
On Fri, Jul 06, 2018 at 04:24:27PM -0700, Darren Hart wrote: > On Thu, Jul 05, 2018 at 03:47:03PM -0500, Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > where we are expecting to fall through. > > > > Signed-off-by: Gustavo A. R. Silva > >

Re: [PATCH] platform/x86: sony-laptop: Mark expected switch fall-through

2018-07-07 Thread Mattia Dongili
On Fri, Jul 06, 2018 at 04:24:27PM -0700, Darren Hart wrote: > On Thu, Jul 05, 2018 at 03:47:03PM -0500, Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > where we are expecting to fall through. > > > > Signed-off-by: Gustavo A. R. Silva > >

Re: [PATCH] platform/x86: sony-laptop: Mark expected switch fall-through

2018-07-07 Thread Andy Shevchenko
On Sat, Jul 7, 2018 at 2:24 AM, Darren Hart wrote: > return AE_CTRL_TERMINATE; > > Is unreachable as there are no "break" statements in the switch, and the > default > falls through to return AE_OK. Something doesn't seem right here. Darren, I didn't look at the code in question,

Re: [PATCH] platform/x86: sony-laptop: Mark expected switch fall-through

2018-07-07 Thread Andy Shevchenko
On Sat, Jul 7, 2018 at 2:24 AM, Darren Hart wrote: > return AE_CTRL_TERMINATE; > > Is unreachable as there are no "break" statements in the switch, and the > default > falls through to return AE_OK. Something doesn't seem right here. Darren, I didn't look at the code in question,

Re: [PATCH] platform/x86: sony-laptop: Mark expected switch fall-through

2018-07-06 Thread Darren Hart
On Thu, Jul 05, 2018 at 03:47:03PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/platform/x86/sony-laptop.c | 1 + > 1 file changed, 1

Re: [PATCH] platform/x86: sony-laptop: Mark expected switch fall-through

2018-07-06 Thread Darren Hart
On Thu, Jul 05, 2018 at 03:47:03PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/platform/x86/sony-laptop.c | 1 + > 1 file changed, 1

[PATCH] platform/x86: sony-laptop: Mark expected switch fall-through

2018-07-05 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- drivers/platform/x86/sony-laptop.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/sony-laptop.c

[PATCH] platform/x86: sony-laptop: Mark expected switch fall-through

2018-07-05 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- drivers/platform/x86/sony-laptop.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/sony-laptop.c