Re: [PATCH] platform: x86: dell-smo8800: remove redundant assignments to byte_data

2017-11-03 Thread Andy Shevchenko
On Tue, Oct 31, 2017 at 8:41 PM, Pali Rohár wrote: > On Tuesday 31 October 2017 20:08:45 Andy Shevchenko wrote: >> On Tue, Oct 31, 2017 at 4:13 PM, Pali Rohár wrote: >> > On Tuesday 31 October 2017 16:07:25 Andy Shevchenko wrote: >> >> On Tue, Oct 31,

Re: [PATCH] platform: x86: dell-smo8800: remove redundant assignments to byte_data

2017-11-03 Thread Andy Shevchenko
On Tue, Oct 31, 2017 at 8:41 PM, Pali Rohár wrote: > On Tuesday 31 October 2017 20:08:45 Andy Shevchenko wrote: >> On Tue, Oct 31, 2017 at 4:13 PM, Pali Rohár wrote: >> > On Tuesday 31 October 2017 16:07:25 Andy Shevchenko wrote: >> >> On Tue, Oct 31, 2017 at 3:55 PM, Pali Rohár wrote: >> >> >

Re: [PATCH] platform: x86: dell-smo8800: remove redundant assignments to byte_data

2017-10-31 Thread Pali Rohár
On Tuesday 31 October 2017 20:08:45 Andy Shevchenko wrote: > On Tue, Oct 31, 2017 at 4:13 PM, Pali Rohár wrote: > > On Tuesday 31 October 2017 16:07:25 Andy Shevchenko wrote: > >> On Tue, Oct 31, 2017 at 3:55 PM, Pali Rohár wrote: > >> > On Tuesday 31

Re: [PATCH] platform: x86: dell-smo8800: remove redundant assignments to byte_data

2017-10-31 Thread Pali Rohár
On Tuesday 31 October 2017 20:08:45 Andy Shevchenko wrote: > On Tue, Oct 31, 2017 at 4:13 PM, Pali Rohár wrote: > > On Tuesday 31 October 2017 16:07:25 Andy Shevchenko wrote: > >> On Tue, Oct 31, 2017 at 3:55 PM, Pali Rohár wrote: > >> > On Tuesday 31 October 2017 15:47:58 Andy Shevchenko wrote:

Re: [PATCH] platform: x86: dell-smo8800: remove redundant assignments to byte_data

2017-10-31 Thread Andy Shevchenko
On Tue, Oct 31, 2017 at 4:13 PM, Pali Rohár wrote: > On Tuesday 31 October 2017 16:07:25 Andy Shevchenko wrote: >> On Tue, Oct 31, 2017 at 3:55 PM, Pali Rohár wrote: >> > On Tuesday 31 October 2017 15:47:58 Andy Shevchenko wrote: >> >> On Tue, Oct 31,

Re: [PATCH] platform: x86: dell-smo8800: remove redundant assignments to byte_data

2017-10-31 Thread Andy Shevchenko
On Tue, Oct 31, 2017 at 4:13 PM, Pali Rohár wrote: > On Tuesday 31 October 2017 16:07:25 Andy Shevchenko wrote: >> On Tue, Oct 31, 2017 at 3:55 PM, Pali Rohár wrote: >> > On Tuesday 31 October 2017 15:47:58 Andy Shevchenko wrote: >> >> On Tue, Oct 31, 2017 at 1:03 PM, Colin King >> >> wrote:

Re: [PATCH] platform: x86: dell-smo8800: remove redundant assignments to byte_data

2017-10-31 Thread Pali Rohár
On Tuesday 31 October 2017 16:07:25 Andy Shevchenko wrote: > On Tue, Oct 31, 2017 at 3:55 PM, Pali Rohár wrote: > > On Tuesday 31 October 2017 15:47:58 Andy Shevchenko wrote: > >> On Tue, Oct 31, 2017 at 1:03 PM, Colin King > >> wrote: > >> >

Re: [PATCH] platform: x86: dell-smo8800: remove redundant assignments to byte_data

2017-10-31 Thread Pali Rohár
On Tuesday 31 October 2017 16:07:25 Andy Shevchenko wrote: > On Tue, Oct 31, 2017 at 3:55 PM, Pali Rohár wrote: > > On Tuesday 31 October 2017 15:47:58 Andy Shevchenko wrote: > >> On Tue, Oct 31, 2017 at 1:03 PM, Colin King > >> wrote: > >> > From: Colin Ian King > >> > > >> > Variable

Re: [PATCH] platform: x86: dell-smo8800: remove redundant assignments to byte_data

2017-10-31 Thread Andy Shevchenko
On Tue, Oct 31, 2017 at 3:55 PM, Pali Rohár wrote: > On Tuesday 31 October 2017 15:47:58 Andy Shevchenko wrote: >> On Tue, Oct 31, 2017 at 1:03 PM, Colin King wrote: >> > From: Colin Ian King >> > >> > Variable byte_data

Re: [PATCH] platform: x86: dell-smo8800: remove redundant assignments to byte_data

2017-10-31 Thread Andy Shevchenko
On Tue, Oct 31, 2017 at 3:55 PM, Pali Rohár wrote: > On Tuesday 31 October 2017 15:47:58 Andy Shevchenko wrote: >> On Tue, Oct 31, 2017 at 1:03 PM, Colin King wrote: >> > From: Colin Ian King >> > >> > Variable byte_data is being initialized and re-assigned with values that >> > are never read.

Re: [PATCH] platform: x86: dell-smo8800: remove redundant assignments to byte_data

2017-10-31 Thread Pali Rohár
On Tuesday 31 October 2017 15:47:58 Andy Shevchenko wrote: > On Tue, Oct 31, 2017 at 1:03 PM, Colin King wrote: > > From: Colin Ian King > > > > Variable byte_data is being initialized and re-assigned with values that > > are never read. Remove

Re: [PATCH] platform: x86: dell-smo8800: remove redundant assignments to byte_data

2017-10-31 Thread Pali Rohár
On Tuesday 31 October 2017 15:47:58 Andy Shevchenko wrote: > On Tue, Oct 31, 2017 at 1:03 PM, Colin King wrote: > > From: Colin Ian King > > > > Variable byte_data is being initialized and re-assigned with values that > > are never read. Remove these as these redundant assignments. Cleans up > >

Re: [PATCH] platform: x86: dell-smo8800: remove redundant assignments to byte_data

2017-10-31 Thread Andy Shevchenko
On Tue, Oct 31, 2017 at 1:03 PM, Colin King wrote: > From: Colin Ian King > > Variable byte_data is being initialized and re-assigned with values that > are never read. Remove these as these redundant assignments. Cleans up > clang warning: > >

Re: [PATCH] platform: x86: dell-smo8800: remove redundant assignments to byte_data

2017-10-31 Thread Andy Shevchenko
On Tue, Oct 31, 2017 at 1:03 PM, Colin King wrote: > From: Colin Ian King > > Variable byte_data is being initialized and re-assigned with values that > are never read. Remove these as these redundant assignments. Cleans up > clang warning: > > drivers/platform/x86/dell-smo8800.c:106:2: warning:

[PATCH] platform: x86: dell-smo8800: remove redundant assignments to byte_data

2017-10-31 Thread Colin King
From: Colin Ian King Variable byte_data is being initialized and re-assigned with values that are never read. Remove these as these redundant assignments. Cleans up clang warning: drivers/platform/x86/dell-smo8800.c:106:2: warning: Value stored to 'byte_data' is never

[PATCH] platform: x86: dell-smo8800: remove redundant assignments to byte_data

2017-10-31 Thread Colin King
From: Colin Ian King Variable byte_data is being initialized and re-assigned with values that are never read. Remove these as these redundant assignments. Cleans up clang warning: drivers/platform/x86/dell-smo8800.c:106:2: warning: Value stored to 'byte_data' is never read Signed-off-by: Colin