Re: [PATCH] power: bq27x00_battery: add bq27510 support

2015-02-28 Thread Sebastian Reichel
Hi Alexandre, On Sat, Feb 28, 2015 at 02:22:23PM +0100, Alexandre Belloni wrote: > Hi, > > On 25/02/2015 at 23:17:48 +0100, Sebastian Reichel wrote : > > > @@ -350,6 +378,9 @@ static int bq27x00_battery_read_cyct(struct > > > bq27x00_device_info *di) > > > { > > > int cyct; > > > > > > + >

Re: [PATCH] power: bq27x00_battery: add bq27510 support

2015-02-28 Thread Alexandre Belloni
Hi, On 25/02/2015 at 23:17:48 +0100, Sebastian Reichel wrote : > > @@ -350,6 +378,9 @@ static int bq27x00_battery_read_cyct(struct > > bq27x00_device_info *di) > > { > > int cyct; > > > > + > > spurious newline. > > > + if (di->chip == BQ27510) > > + cyct = bq27x00_read(di,

Re: [PATCH] power: bq27x00_battery: add bq27510 support

2015-02-28 Thread Alexandre Belloni
Hi, On 25/02/2015 at 23:17:48 +0100, Sebastian Reichel wrote : @@ -350,6 +378,9 @@ static int bq27x00_battery_read_cyct(struct bq27x00_device_info *di) { int cyct; + spurious newline. + if (di-chip == BQ27510) + cyct = bq27x00_read(di, BQ27510_REG_CYCT,

Re: [PATCH] power: bq27x00_battery: add bq27510 support

2015-02-28 Thread Sebastian Reichel
Hi Alexandre, On Sat, Feb 28, 2015 at 02:22:23PM +0100, Alexandre Belloni wrote: Hi, On 25/02/2015 at 23:17:48 +0100, Sebastian Reichel wrote : @@ -350,6 +378,9 @@ static int bq27x00_battery_read_cyct(struct bq27x00_device_info *di) { int cyct; + spurious newline.

Re: [PATCH] power: bq27x00_battery: add bq27510 support

2015-02-25 Thread Sebastian Reichel
Hi Alexandre, On Sun, Feb 22, 2015 at 03:08:31PM +0100, Alexandre Belloni wrote: > Add support for bq27510 to the bq27x00 driver. > > Signed-off-by: Alexandre Belloni patch looks mostly fine to me, I have two comments (inline). -- Sebastian > --- > drivers/power/bq27x00_battery.c | 50 >

Re: [PATCH] power: bq27x00_battery: add bq27510 support

2015-02-25 Thread Sebastian Reichel
Hi Alexandre, On Sun, Feb 22, 2015 at 03:08:31PM +0100, Alexandre Belloni wrote: Add support for bq27510 to the bq27x00 driver. Signed-off-by: Alexandre Belloni alexandre.bell...@free-electrons.com patch looks mostly fine to me, I have two comments (inline). -- Sebastian ---

[PATCH] power: bq27x00_battery: add bq27510 support

2015-02-22 Thread Alexandre Belloni
Add support for bq27510 to the bq27x00 driver. Signed-off-by: Alexandre Belloni --- drivers/power/bq27x00_battery.c | 50 - 1 file changed, 45 insertions(+), 5 deletions(-) diff --git a/drivers/power/bq27x00_battery.c b/drivers/power/bq27x00_battery.c

[PATCH] power: bq27x00_battery: add bq27510 support

2015-02-22 Thread Alexandre Belloni
Add support for bq27510 to the bq27x00 driver. Signed-off-by: Alexandre Belloni alexandre.bell...@free-electrons.com --- drivers/power/bq27x00_battery.c | 50 - 1 file changed, 45 insertions(+), 5 deletions(-) diff --git a/drivers/power/bq27x00_battery.c