Re: [PATCH] powerpc: Fix fs_enet module build

2007-11-14 Thread David Miller
From: Jochen Friedrich <[EMAIL PROTECTED]> Date: Wed, 14 Nov 2007 12:59:33 +0100 > I know it's ugly, however, module building is completely > broken right now and I just want to provide a quick and > ugly fix until both that ppc->powerpc transition and the > new binding transition are over. Noone

Re: [PATCH] powerpc: Fix fs_enet module build

2007-11-14 Thread Jochen Friedrich
Hi David, > This is truly ugly and creates an unnecessarily hard to > maintain and complex driver. > > Please find a way to fix this for real, so that the > PPC_CPM_NEW_BINDING ifdef is not necessary at all and > things get built modular or not naturally as we handle > things for other cases

Re: [PATCH] powerpc: Fix fs_enet module build

2007-11-14 Thread Jochen Friedrich
Hi David, This is truly ugly and creates an unnecessarily hard to maintain and complex driver. Please find a way to fix this for real, so that the PPC_CPM_NEW_BINDING ifdef is not necessary at all and things get built modular or not naturally as we handle things for other cases like this.

Re: [PATCH] powerpc: Fix fs_enet module build

2007-11-14 Thread David Miller
From: Jochen Friedrich [EMAIL PROTECTED] Date: Wed, 14 Nov 2007 12:59:33 +0100 I know it's ugly, however, module building is completely broken right now and I just want to provide a quick and ugly fix until both that ppc-powerpc transition and the new binding transition are over. Noone wants

Re: [PATCH] powerpc: Fix fs_enet module build

2007-11-13 Thread David Miller
From: Jochen Friedrich <[EMAIL PROTECTED]> Date: Tue, 13 Nov 2007 19:32:08 +0100 > If fs_enet is build as module, on PPC_CPM_NEW_BINDING platforms > mii-fec/mii-bitbang should be build as module, as well. On other > platforms, mii-fec/mii-bitbang must be included into the main module. > Otherwise

[PATCH] powerpc: Fix fs_enet module build

2007-11-13 Thread Jochen Friedrich
If fs_enet is build as module, on PPC_CPM_NEW_BINDING platforms mii-fec/mii-bitbang should be build as module, as well. On other platforms, mii-fec/mii-bitbang must be included into the main module. Otherwise some symbols remain undefined. Additionally, fs_enet uses libphy, so add a select

[PATCH] powerpc: Fix fs_enet module build

2007-11-13 Thread Jochen Friedrich
If fs_enet is build as module, on PPC_CPM_NEW_BINDING platforms mii-fec/mii-bitbang should be build as module, as well. On other platforms, mii-fec/mii-bitbang must be included into the main module. Otherwise some symbols remain undefined. Additionally, fs_enet uses libphy, so add a select

Re: [PATCH] powerpc: Fix fs_enet module build

2007-11-13 Thread David Miller
From: Jochen Friedrich [EMAIL PROTECTED] Date: Tue, 13 Nov 2007 19:32:08 +0100 If fs_enet is build as module, on PPC_CPM_NEW_BINDING platforms mii-fec/mii-bitbang should be build as module, as well. On other platforms, mii-fec/mii-bitbang must be included into the main module. Otherwise some

Re: [PATCH] [POWERPC] Fix fs_enet module build

2007-11-05 Thread Scott Wood
Jochen Friedrich wrote: diff --git a/drivers/net/fs_enet/Makefile b/drivers/net/fs_enet/Makefile index 02d4dc1..2f7563a 100644 --- a/drivers/net/fs_enet/Makefile +++ b/drivers/net/fs_enet/Makefile @@ -4,7 +4,15 @@ obj-$(CONFIG_FS_ENET) += fs_enet.o -obj-$(CONFIG_8xx) += mac-fec.o mac-scc.o

Re: [PATCH] [POWERPC] Fix fs_enet module build

2007-11-05 Thread Scott Wood
Jochen Friedrich wrote: diff --git a/drivers/net/fs_enet/Makefile b/drivers/net/fs_enet/Makefile index 02d4dc1..2f7563a 100644 --- a/drivers/net/fs_enet/Makefile +++ b/drivers/net/fs_enet/Makefile @@ -4,7 +4,15 @@ obj-$(CONFIG_FS_ENET) += fs_enet.o -obj-$(CONFIG_8xx) += mac-fec.o mac-scc.o

[PATCH] [POWERPC] Fix fs_enet module build

2007-11-03 Thread Jochen Friedrich
If fs_enet is build as module, mii-fec/mii-bitbang should be build as module, as well. Otherwise some symbols remain undefined. Building modules, stage 2. MODPOST 5 modules ERROR: "fs_scc_ops" [drivers/net/fs_enet/fs_enet.ko] undefined! make[1]: *** [__modpost] Error 1 make: *** [modules]

[PATCH] [POWERPC] Fix fs_enet module build

2007-11-03 Thread Jochen Friedrich
If fs_enet is build as module, mii-fec/mii-bitbang should be build as module, as well. Otherwise some symbols remain undefined. Building modules, stage 2. MODPOST 5 modules ERROR: fs_scc_ops [drivers/net/fs_enet/fs_enet.ko] undefined! make[1]: *** [__modpost] Error 1 make: *** [modules] Error