Re: [PATCH] proc: revert /proc/*/cmdline rewrite

2019-07-14 Thread Linus Torvalds
On Sun, Jul 14, 2019 at 2:52 AM Alexey Dobriyan wrote: > > The problem is that I can't even drag this trivia in out of _fear_ that > it is userspace observable: > > https://marc.info/?t=15586342972=1=4 > [PATCH] elf: fix "start_code" evaluation Oh, we should do things like

Re: [PATCH] proc: revert /proc/*/cmdline rewrite

2019-07-14 Thread Alexey Dobriyan
[re-add lists] On Sat, Jul 13, 2019 at 10:50:20AM -0700, Linus Torvalds wrote: > On Sat, Jul 13, 2019 at 12:29 AM Alexey Dobriyan wrote: > > > > /proc/*/cmdline continues to cause problems: > > If we're reverting this, then we should revert all the way back to the > original

Re: [PATCH] proc: revert /proc/*/cmdline rewrite

2019-07-13 Thread Linus Torvalds
[ Apparently this thread wasn't on the lists, and I didn't even notice. So re-sending the patches ] On Sat, Jul 13, 2019 at 9:16 PM Eric W. Biederman wrote: > Given that this fixes a regression and a bug. > > Acked-by: "Eric W. Biederman" I'd much rather start from scratch. Like the attached.

Re: [PATCH] proc: revert /proc/*/cmdline rewrite

2019-07-13 Thread Eric W. Biederman
Alexey Dobriyan writes: > /proc/*/cmdline continues to cause problems: > > https://lkml.org/lkml/2019/4/5/825 > Subject get_mm_cmdline and userspace (Perl) changing argv0 > > https://marc.info/?l=linux-kernel=156294831308786=4 > [PATCH] proc: Fix uninitialized byte read

Re: [PATCH] proc: revert /proc/*/cmdline rewrite

2019-07-13 Thread Alexey Izbyshev
On 7/13/19 10:32 AM, Alexey Dobriyan wrote: > /proc/*/cmdline continues to cause problems: > > https://lkml.org/lkml/2019/4/5/825 > Subject get_mm_cmdline and userspace (Perl) changing argv0 > > https://marc.info/?l=linux-kernel=156294831308786=4 > [PATCH] proc: Fix

[PATCH] proc: revert /proc/*/cmdline rewrite

2019-07-13 Thread Alexey Dobriyan
/proc/*/cmdline continues to cause problems: https://lkml.org/lkml/2019/4/5/825 Subject get_mm_cmdline and userspace (Perl) changing argv0 https://marc.info/?l=linux-kernel=156294831308786=4 [PATCH] proc: Fix uninitialized byte read in get_mm_cmdline() This patch