Re: [PATCH] proc_sysctl: clamp sizes using table->maxlen

2021-02-27 Thread Alex Xu (Hello71)
Excerpts from Christoph Hellwig's message of February 16, 2021 3:47 am: > How do these maxlen = 0 entries even survive the sysctl_check_table > check? maxlen!=0 is only checked for "default" handlers, e.g. proc_dostring, proc_dointvec. it is not checked for non-default handlers, because some of

Re: [PATCH] proc_sysctl: clamp sizes using table->maxlen

2021-02-16 Thread Christoph Hellwig
On Mon, Feb 15, 2021 at 09:53:05AM -0500, Alex Xu (Hello71) wrote: > Since maxlen is already exposed, we can allocate approximately the right > amount directly, fixing up those drivers which set a bogus maxlen. These > drivers were located based on those which had copy_x_user replaced in > 32927393

Re: [PATCH] proc_sysctl: clamp sizes using table->maxlen

2021-02-15 Thread Alex Xu (Hello71)
Excerpts from Alex Xu (Hello71)'s message of February 15, 2021 9:53 am: > This issue was discussed at [0] and following, and the solution was to > clamp the size at KMALLOC_MAX_LEN. However, KMALLOC_MAX_LEN is a maximum > allocation, and may be difficult to allocate in low memory conditions. > > S

[PATCH] proc_sysctl: clamp sizes using table->maxlen

2021-02-15 Thread Alex Xu (Hello71)
This issue was discussed at [0] and following, and the solution was to clamp the size at KMALLOC_MAX_LEN. However, KMALLOC_MAX_LEN is a maximum allocation, and may be difficult to allocate in low memory conditions. Since maxlen is already exposed, we can allocate approximately the right amount dir