Re: [PATCH] psi: Don't account force reclaim as memory pressure

2019-06-15 Thread Xunlei Pang
Hi Chris, On 2019/6/15 PM 11:58, Chris Down wrote: > Hi Xunlei, > > Xunlei Pang writes: >> There're several cases like resize and force_empty that don't >> need to account to psi, otherwise is misleading. > > I'm afraid I'm quite confused by this patch. Why do you think accounting > for force

Re: [PATCH] psi: Don't account force reclaim as memory pressure

2019-06-15 Thread Chris Down
Hi Xunlei, Xunlei Pang writes: There're several cases like resize and force_empty that don't need to account to psi, otherwise is misleading. I'm afraid I'm quite confused by this patch. Why do you think accounting for force reclaim in PSI is misleading? I completely expect that force

[PATCH] psi: Don't account force reclaim as memory pressure

2019-06-15 Thread Xunlei Pang
There're several cases like resize and force_empty that don't need to account to psi, otherwise is misleading. We also have a module reclaiming dying memcgs at background to avoid too many dead memcgs which can cause lots of trouble, then it makes the psi inaccuracy even worse without this patch.