Re: [PATCH] pstore: Fix bool initialization/comparison

2018-11-29 Thread Kees Cook
On Sat, Oct 7, 2017 at 7:24 AM Thomas Meyer wrote: > Bool initializations should use true and false. Bool tests don't need > comparisons. > > Signed-off-by: Thomas Meyer I totally missed this email (now over a year ago!) However, since it's still correct and applies, I've taken it for -next

Re: [PATCH] pstore: Fix bool initialization/comparison

2018-11-29 Thread Kees Cook
On Sat, Oct 7, 2017 at 7:24 AM Thomas Meyer wrote: > Bool initializations should use true and false. Bool tests don't need > comparisons. > > Signed-off-by: Thomas Meyer I totally missed this email (now over a year ago!) However, since it's still correct and applies, I've taken it for -next

[PATCH] pstore: Fix bool initialization/comparison

2017-10-07 Thread Thomas Meyer
Bool initializations should use true and false. Bool tests don't need comparisons. Signed-off-by: Thomas Meyer --- diff -u -p a/fs/pstore/ftrace.c b/fs/pstore/ftrace.c --- a/fs/pstore/ftrace.c +++ b/fs/pstore/ftrace.c @@ -148,7 +148,7 @@ void pstore_unregister_ftrace(void)

[PATCH] pstore: Fix bool initialization/comparison

2017-10-07 Thread Thomas Meyer
Bool initializations should use true and false. Bool tests don't need comparisons. Signed-off-by: Thomas Meyer --- diff -u -p a/fs/pstore/ftrace.c b/fs/pstore/ftrace.c --- a/fs/pstore/ftrace.c +++ b/fs/pstore/ftrace.c @@ -148,7 +148,7 @@ void pstore_unregister_ftrace(void)