Re: [PATCH] pstore: add missed platform_device_unregister

2012-08-21 Thread Anton Vorontsov 
On Tue, Aug 21, 2012 at 09:19:15AM -0700, Kees Cook wrote:
[...]
> >>  static void __exit ramoops_exit(void)
> >>  {
> >>   platform_driver_unregister(_driver);
> >> + platform_device_unregister(dummy);
> >>   kfree(dummy_data);
> >>  }
> >>  module_exit(ramoops_exit);
> >
> > It looks OK to me. Unless there are objections I'll apply it to
> > linux-pstore.git.
> 
> Yup, looks right.
> 
> Acked-by: Kees Cook 

Applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] pstore: add missed platform_device_unregister

2012-08-21 Thread Kees Cook 
On Mon, Aug 20, 2012 at 6:40 PM, Anton Vorontsov  wrote:
> On Mon, Aug 20, 2012 at 02:58:26PM +0800, Jovi Zhang wrote:
>> From 152373a6262045d19023cf45de84ad3c69316a45 Mon Sep 17 00:00:00 2001
>> From: Jovi Zhang 
>> Date: Mon, 20 Aug 2012 14:20:01 +0800
>> Subject: [PATCH] pstore: add missed platform_device_unregister
>>
>> we need unregister platform device when module exit, add it.
>>
>> Signed-off-by: Jovi Zhang 
>> ---
>>  fs/pstore/ram.c |1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
>> index 0b311bc..adb218a 100644
>> --- a/fs/pstore/ram.c
>> +++ b/fs/pstore/ram.c
>> @@ -537,6 +537,7 @@ postcore_initcall(ramoops_init);
>>  static void __exit ramoops_exit(void)
>>  {
>>   platform_driver_unregister(_driver);
>> + platform_device_unregister(dummy);
>>   kfree(dummy_data);
>>  }
>>  module_exit(ramoops_exit);
>
> It looks OK to me. Unless there are objections I'll apply it to
> linux-pstore.git.

Yup, looks right.

Acked-by: Kees Cook 

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] pstore: add missed platform_device_unregister

2012-08-21 Thread Anton Vorontsov 
On Tue, Aug 21, 2012 at 09:19:15AM -0700, Kees Cook wrote:
[...]
   static void __exit ramoops_exit(void)
   {
platform_driver_unregister(ramoops_driver);
  + platform_device_unregister(dummy);
kfree(dummy_data);
   }
   module_exit(ramoops_exit);
 
  It looks OK to me. Unless there are objections I'll apply it to
  linux-pstore.git.
 
 Yup, looks right.
 
 Acked-by: Kees Cook keesc...@chromium.org

Applied, thanks!
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] pstore: add missed platform_device_unregister

2012-08-21 Thread Kees Cook 
On Mon, Aug 20, 2012 at 6:40 PM, Anton Vorontsov cbouatmai...@gmail.com wrote:
 On Mon, Aug 20, 2012 at 02:58:26PM +0800, Jovi Zhang wrote:
 From 152373a6262045d19023cf45de84ad3c69316a45 Mon Sep 17 00:00:00 2001
 From: Jovi Zhang bookj...@gmail.com
 Date: Mon, 20 Aug 2012 14:20:01 +0800
 Subject: [PATCH] pstore: add missed platform_device_unregister

 we need unregister platform device when module exit, add it.

 Signed-off-by: Jovi Zhang bookj...@gmail.com
 ---
  fs/pstore/ram.c |1 +
  1 file changed, 1 insertion(+)

 diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
 index 0b311bc..adb218a 100644
 --- a/fs/pstore/ram.c
 +++ b/fs/pstore/ram.c
 @@ -537,6 +537,7 @@ postcore_initcall(ramoops_init);
  static void __exit ramoops_exit(void)
  {
   platform_driver_unregister(ramoops_driver);
 + platform_device_unregister(dummy);
   kfree(dummy_data);
  }
  module_exit(ramoops_exit);

 It looks OK to me. Unless there are objections I'll apply it to
 linux-pstore.git.

Yup, looks right.

Acked-by: Kees Cook keesc...@chromium.org

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] pstore: add missed platform_device_unregister

2012-08-20 Thread Anton Vorontsov 
On Mon, Aug 20, 2012 at 02:58:26PM +0800, Jovi Zhang wrote:
> From 152373a6262045d19023cf45de84ad3c69316a45 Mon Sep 17 00:00:00 2001
> From: Jovi Zhang 
> Date: Mon, 20 Aug 2012 14:20:01 +0800
> Subject: [PATCH] pstore: add missed platform_device_unregister
> 
> we need unregister platform device when module exit, add it.
> 
> Signed-off-by: Jovi Zhang 
> ---
>  fs/pstore/ram.c |1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
> index 0b311bc..adb218a 100644
> --- a/fs/pstore/ram.c
> +++ b/fs/pstore/ram.c
> @@ -537,6 +537,7 @@ postcore_initcall(ramoops_init);
>  static void __exit ramoops_exit(void)
>  {
>   platform_driver_unregister(_driver);
> + platform_device_unregister(dummy);
>   kfree(dummy_data);
>  }
>  module_exit(ramoops_exit);

It looks OK to me. Unless there are objections I'll apply it to
linux-pstore.git.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] pstore: add missed platform_device_unregister

2012-08-20 Thread Jovi Zhang 
>From 152373a6262045d19023cf45de84ad3c69316a45 Mon Sep 17 00:00:00 2001
From: Jovi Zhang 
Date: Mon, 20 Aug 2012 14:20:01 +0800
Subject: [PATCH] pstore: add missed platform_device_unregister

we need unregister platform device when module exit, add it.

Signed-off-by: Jovi Zhang 
---
 fs/pstore/ram.c |1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
index 0b311bc..adb218a 100644
--- a/fs/pstore/ram.c
+++ b/fs/pstore/ram.c
@@ -537,6 +537,7 @@ postcore_initcall(ramoops_init);
 static void __exit ramoops_exit(void)
 {
platform_driver_unregister(_driver);
+   platform_device_unregister(dummy);
kfree(dummy_data);
 }
 module_exit(ramoops_exit);
-- 
1.7.9.7
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] pstore: add missed platform_device_unregister

2012-08-20 Thread Jovi Zhang 
From 152373a6262045d19023cf45de84ad3c69316a45 Mon Sep 17 00:00:00 2001
From: Jovi Zhang bookj...@gmail.com
Date: Mon, 20 Aug 2012 14:20:01 +0800
Subject: [PATCH] pstore: add missed platform_device_unregister

we need unregister platform device when module exit, add it.

Signed-off-by: Jovi Zhang bookj...@gmail.com
---
 fs/pstore/ram.c |1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
index 0b311bc..adb218a 100644
--- a/fs/pstore/ram.c
+++ b/fs/pstore/ram.c
@@ -537,6 +537,7 @@ postcore_initcall(ramoops_init);
 static void __exit ramoops_exit(void)
 {
platform_driver_unregister(ramoops_driver);
+   platform_device_unregister(dummy);
kfree(dummy_data);
 }
 module_exit(ramoops_exit);
-- 
1.7.9.7
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] pstore: add missed platform_device_unregister

2012-08-20 Thread Anton Vorontsov 
On Mon, Aug 20, 2012 at 02:58:26PM +0800, Jovi Zhang wrote:
 From 152373a6262045d19023cf45de84ad3c69316a45 Mon Sep 17 00:00:00 2001
 From: Jovi Zhang bookj...@gmail.com
 Date: Mon, 20 Aug 2012 14:20:01 +0800
 Subject: [PATCH] pstore: add missed platform_device_unregister
 
 we need unregister platform device when module exit, add it.
 
 Signed-off-by: Jovi Zhang bookj...@gmail.com
 ---
  fs/pstore/ram.c |1 +
  1 file changed, 1 insertion(+)
 
 diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
 index 0b311bc..adb218a 100644
 --- a/fs/pstore/ram.c
 +++ b/fs/pstore/ram.c
 @@ -537,6 +537,7 @@ postcore_initcall(ramoops_init);
  static void __exit ramoops_exit(void)
  {
   platform_driver_unregister(ramoops_driver);
 + platform_device_unregister(dummy);
   kfree(dummy_data);
  }
  module_exit(ramoops_exit);

It looks OK to me. Unless there are objections I'll apply it to
linux-pstore.git.

Thanks!
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/