Re: [PATCH] pwm: lpss: remove dependency on clk framework

2014-08-07 Thread Thierry Reding
On Fri, May 09, 2014 at 11:35:21AM +0300, Heikki Krogerus wrote: > Unlike other Intel LPSS devices, the PWM does not have the > clock dividers or the gate. All we get from the clock is the > rate. Since PCI case uses the driver data to get the rate, > we can drop the clk and use the same data also

Re: [PATCH] pwm: lpss: remove dependency on clk framework

2014-08-07 Thread Thierry Reding
On Fri, May 09, 2014 at 11:35:21AM +0300, Heikki Krogerus wrote: Unlike other Intel LPSS devices, the PWM does not have the clock dividers or the gate. All we get from the clock is the rate. Since PCI case uses the driver data to get the rate, we can drop the clk and use the same data also in

RE: [PATCH] pwm: lpss: remove dependency on clk framework

2014-05-14 Thread Chew, Chiau Ee
> > Hi, > > On Wed, May 14, 2014 at 07:00:59AM +, Chew, Chiau Ee wrote: > > Heikki, > > For ACPI mode, the clock rate information for PWM is being setup in the > acpi_lpss.c layer. > > Thus, only PCI mode depends on the driver_data to pass in the clock rate > information. > > The goal with

Re: [PATCH] pwm: lpss: remove dependency on clk framework

2014-05-14 Thread Heikki Krogerus
Hi, On Wed, May 14, 2014 at 07:00:59AM +, Chew, Chiau Ee wrote: > Heikki, > For ACPI mode, the clock rate information for PWM is being setup in the > acpi_lpss.c layer. > Thus, only PCI mode depends on the driver_data to pass in the clock rate > information. The goal with this patch is

RE: [PATCH] pwm: lpss: remove dependency on clk framework

2014-05-14 Thread Chew, Chiau Ee
> Unlike other Intel LPSS devices, the PWM does not have the clock dividers or > the gate. All we get from the clock is the rate. Since PCI case uses the > driver > data to get the rate, we can drop the clk and use the same data also in case > of > ACPI. The frequency is the same. > >

RE: [PATCH] pwm: lpss: remove dependency on clk framework

2014-05-14 Thread Chew, Chiau Ee
Unlike other Intel LPSS devices, the PWM does not have the clock dividers or the gate. All we get from the clock is the rate. Since PCI case uses the driver data to get the rate, we can drop the clk and use the same data also in case of ACPI. The frequency is the same. Signed-off-by:

Re: [PATCH] pwm: lpss: remove dependency on clk framework

2014-05-14 Thread Heikki Krogerus
Hi, On Wed, May 14, 2014 at 07:00:59AM +, Chew, Chiau Ee wrote: Heikki, For ACPI mode, the clock rate information for PWM is being setup in the acpi_lpss.c layer. Thus, only PCI mode depends on the driver_data to pass in the clock rate information. The goal with this patch is actually

RE: [PATCH] pwm: lpss: remove dependency on clk framework

2014-05-14 Thread Chew, Chiau Ee
Hi, On Wed, May 14, 2014 at 07:00:59AM +, Chew, Chiau Ee wrote: Heikki, For ACPI mode, the clock rate information for PWM is being setup in the acpi_lpss.c layer. Thus, only PCI mode depends on the driver_data to pass in the clock rate information. The goal with this patch is

Re: [PATCH] pwm: lpss: remove dependency on clk framework

2014-05-12 Thread Mika Westerberg
On Fri, May 09, 2014 at 11:35:21AM +0300, Heikki Krogerus wrote: > Unlike other Intel LPSS devices, the PWM does not have the > clock dividers or the gate. All we get from the clock is the > rate. Since PCI case uses the driver data to get the rate, > we can drop the clk and use the same data also

Re: [PATCH] pwm: lpss: remove dependency on clk framework

2014-05-12 Thread Mika Westerberg
On Fri, May 09, 2014 at 11:35:21AM +0300, Heikki Krogerus wrote: Unlike other Intel LPSS devices, the PWM does not have the clock dividers or the gate. All we get from the clock is the rate. Since PCI case uses the driver data to get the rate, we can drop the clk and use the same data also in

[PATCH] pwm: lpss: remove dependency on clk framework

2014-05-09 Thread Heikki Krogerus
Unlike other Intel LPSS devices, the PWM does not have the clock dividers or the gate. All we get from the clock is the rate. Since PCI case uses the driver data to get the rate, we can drop the clk and use the same data also in case of ACPI. The frequency is the same. Signed-off-by: Heikki

[PATCH] pwm: lpss: remove dependency on clk framework

2014-05-09 Thread Heikki Krogerus
Unlike other Intel LPSS devices, the PWM does not have the clock dividers or the gate. All we get from the clock is the rate. Since PCI case uses the driver data to get the rate, we can drop the clk and use the same data also in case of ACPI. The frequency is the same. Signed-off-by: Heikki