Re: [PATCH] pwm-backlight: add support for device tree gpio control

2013-11-11 Thread Thierry Reding
On Fri, Sep 27, 2013 at 06:35:31AM -0700, Mike Dunn wrote: > On 09/26/2013 05:50 AM, Thierry Reding wrote: > > On Thu, Sep 26, 2013 at 03:26:13PM +0300, Tomi Valkeinen wrote: > >> On 26/09/13 15:02, Thierry Reding wrote: > >>> On Thu, Sep 26, 2013 at 01:13:18PM +0300, Tomi Valkeinen wrote: >

Re: [PATCH] pwm-backlight: add support for device tree gpio control

2013-11-11 Thread Thierry Reding
On Fri, Sep 27, 2013 at 06:35:31AM -0700, Mike Dunn wrote: On 09/26/2013 05:50 AM, Thierry Reding wrote: On Thu, Sep 26, 2013 at 03:26:13PM +0300, Tomi Valkeinen wrote: On 26/09/13 15:02, Thierry Reding wrote: On Thu, Sep 26, 2013 at 01:13:18PM +0300, Tomi Valkeinen wrote: On 11/09/13

Re: [PATCH] pwm-backlight: add support for device tree gpio control

2013-09-27 Thread Mike Dunn
On 09/26/2013 05:50 AM, Thierry Reding wrote: > On Thu, Sep 26, 2013 at 03:26:13PM +0300, Tomi Valkeinen wrote: >> On 26/09/13 15:02, Thierry Reding wrote: >>> On Thu, Sep 26, 2013 at 01:13:18PM +0300, Tomi Valkeinen wrote: On 11/09/13 14:40, Mike Dunn wrote: > On 09/10/2013 10:21 AM,

Re: [PATCH] pwm-backlight: add support for device tree gpio control

2013-09-27 Thread Tomi Valkeinen
On 26/09/13 15:50, Thierry Reding wrote: >> I thought the NAK was for the DT parts, not for the sequences as such. I >> don't remember anyone shooting down the idea of defining power sequences >> inside a driver. > > Yes, but the DT parts were the primary reason why they were written in > the

Re: [PATCH] pwm-backlight: add support for device tree gpio control

2013-09-27 Thread Tomi Valkeinen
On 26/09/13 15:50, Thierry Reding wrote: I thought the NAK was for the DT parts, not for the sequences as such. I don't remember anyone shooting down the idea of defining power sequences inside a driver. Yes, but the DT parts were the primary reason why they were written in the first

Re: [PATCH] pwm-backlight: add support for device tree gpio control

2013-09-27 Thread Mike Dunn
On 09/26/2013 05:50 AM, Thierry Reding wrote: On Thu, Sep 26, 2013 at 03:26:13PM +0300, Tomi Valkeinen wrote: On 26/09/13 15:02, Thierry Reding wrote: On Thu, Sep 26, 2013 at 01:13:18PM +0300, Tomi Valkeinen wrote: On 11/09/13 14:40, Mike Dunn wrote: On 09/10/2013 10:21 AM, Thierry Reding

Re: [PATCH] pwm-backlight: add support for device tree gpio control

2013-09-26 Thread Thierry Reding
On Thu, Sep 26, 2013 at 03:26:13PM +0300, Tomi Valkeinen wrote: > On 26/09/13 15:02, Thierry Reding wrote: > > On Thu, Sep 26, 2013 at 01:13:18PM +0300, Tomi Valkeinen wrote: > >> On 11/09/13 14:40, Mike Dunn wrote: > >>> On 09/10/2013 10:21 AM, Thierry Reding wrote: > >> > Do you have a real

Re: [PATCH] pwm-backlight: add support for device tree gpio control

2013-09-26 Thread Tomi Valkeinen
On 26/09/13 15:02, Thierry Reding wrote: > On Thu, Sep 26, 2013 at 01:13:18PM +0300, Tomi Valkeinen wrote: >> On 11/09/13 14:40, Mike Dunn wrote: >>> On 09/10/2013 10:21 AM, Thierry Reding wrote: >> Do you have a real setup that actually needs multiple GPIOs? Usually such a setup

Re: [PATCH] pwm-backlight: add support for device tree gpio control

2013-09-26 Thread Thierry Reding
On Thu, Sep 26, 2013 at 01:13:18PM +0300, Tomi Valkeinen wrote: > On 11/09/13 14:40, Mike Dunn wrote: > > On 09/10/2013 10:21 AM, Thierry Reding wrote: > > >> Do you have a real setup that actually needs multiple GPIOs? Usually > >> such a setup requires some kind of timing or other additional

Re: [PATCH] pwm-backlight: add support for device tree gpio control

2013-09-26 Thread Tomi Valkeinen
On 11/09/13 14:40, Mike Dunn wrote: > On 09/10/2013 10:21 AM, Thierry Reding wrote: >> Do you have a real setup that actually needs multiple GPIOs? Usually >> such a setup requires some kind of timing or other additional constraint >> which can't be represented by this simple binding. >> >>

Re: [PATCH] pwm-backlight: add support for device tree gpio control

2013-09-26 Thread Tomi Valkeinen
On 11/09/13 14:40, Mike Dunn wrote: On 09/10/2013 10:21 AM, Thierry Reding wrote: Do you have a real setup that actually needs multiple GPIOs? Usually such a setup requires some kind of timing or other additional constraint which can't be represented by this simple binding. Looking at the

Re: [PATCH] pwm-backlight: add support for device tree gpio control

2013-09-26 Thread Thierry Reding
On Thu, Sep 26, 2013 at 01:13:18PM +0300, Tomi Valkeinen wrote: On 11/09/13 14:40, Mike Dunn wrote: On 09/10/2013 10:21 AM, Thierry Reding wrote: Do you have a real setup that actually needs multiple GPIOs? Usually such a setup requires some kind of timing or other additional constraint

Re: [PATCH] pwm-backlight: add support for device tree gpio control

2013-09-26 Thread Tomi Valkeinen
On 26/09/13 15:02, Thierry Reding wrote: On Thu, Sep 26, 2013 at 01:13:18PM +0300, Tomi Valkeinen wrote: On 11/09/13 14:40, Mike Dunn wrote: On 09/10/2013 10:21 AM, Thierry Reding wrote: Do you have a real setup that actually needs multiple GPIOs? Usually such a setup requires some kind of

Re: [PATCH] pwm-backlight: add support for device tree gpio control

2013-09-26 Thread Thierry Reding
On Thu, Sep 26, 2013 at 03:26:13PM +0300, Tomi Valkeinen wrote: On 26/09/13 15:02, Thierry Reding wrote: On Thu, Sep 26, 2013 at 01:13:18PM +0300, Tomi Valkeinen wrote: On 11/09/13 14:40, Mike Dunn wrote: On 09/10/2013 10:21 AM, Thierry Reding wrote: Do you have a real setup that

Re: [PATCH] pwm-backlight: add support for device tree gpio control

2013-09-11 Thread Mike Dunn
On 09/10/2013 10:21 AM, Thierry Reding wrote: > On Tue, Sep 03, 2013 at 12:26:12PM -0700, Mike Dunn wrote: >> This patch adds support for controlling an arbitrary number of gpios to the >> pwm-backlight driver. This was left as a TODO when initial device tree >> support >> was added by Thierry a

Re: [PATCH] pwm-backlight: add support for device tree gpio control

2013-09-11 Thread Mike Dunn
On 09/10/2013 10:21 AM, Thierry Reding wrote: On Tue, Sep 03, 2013 at 12:26:12PM -0700, Mike Dunn wrote: This patch adds support for controlling an arbitrary number of gpios to the pwm-backlight driver. This was left as a TODO when initial device tree support was added by Thierry a while

Re: [PATCH] pwm-backlight: add support for device tree gpio control

2013-09-10 Thread Thierry Reding
On Tue, Sep 03, 2013 at 12:26:12PM -0700, Mike Dunn wrote: > This patch adds support for controlling an arbitrary number of gpios to the > pwm-backlight driver. This was left as a TODO when initial device tree > support > was added by Thierry a while back. This functionality replaces the

Re: [PATCH] pwm-backlight: add support for device tree gpio control

2013-09-10 Thread Thierry Reding
On Tue, Sep 03, 2013 at 12:26:12PM -0700, Mike Dunn wrote: This patch adds support for controlling an arbitrary number of gpios to the pwm-backlight driver. This was left as a TODO when initial device tree support was added by Thierry a while back. This functionality replaces the callbacks

[PATCH] pwm-backlight: add support for device tree gpio control

2013-09-03 Thread Mike Dunn
This patch adds support for controlling an arbitrary number of gpios to the pwm-backlight driver. This was left as a TODO when initial device tree support was added by Thierry a while back. This functionality replaces the callbacks that are passed in the platform data for non-DT cases. Users

[PATCH] pwm-backlight: add support for device tree gpio control

2013-09-03 Thread Mike Dunn
This patch adds support for controlling an arbitrary number of gpios to the pwm-backlight driver. This was left as a TODO when initial device tree support was added by Thierry a while back. This functionality replaces the callbacks that are passed in the platform data for non-DT cases. Users