Re: [PATCH] radix tree: Don't return internal entries on lookup

On Thu, Dec 13, 2018 at 10:43:14AM +0100, Greg Kurz wrote: > I see this fix is in linux-next. I just want to make sure it will > land in 4.20 in order to avoid kernel panics in the OCXL driver. It's in now. Looks like Linus actually pulled it last night but didn't push out the tree until this mor

Re: [PATCH] radix tree: Don't return internal entries on lookup

On Thu, 6 Dec 2018 17:21:02 +0100 Greg Kurz wrote: > On Thu, 6 Dec 2018 05:36:20 -0800 > Matthew Wilcox wrote: > > > On Thu, Dec 06, 2018 at 08:54:03AM +0100, Greg Kurz wrote: > > > Commit 66ee620f06f9 ("idr: Permit any valid kernel pointer to > > > be stored") changed the radix tree lookup s

Re: [PATCH] radix tree: Don't return internal entries on lookup

On Thu, 6 Dec 2018 05:36:20 -0800 Matthew Wilcox wrote: > On Thu, Dec 06, 2018 at 08:54:03AM +0100, Greg Kurz wrote: > > Commit 66ee620f06f9 ("idr: Permit any valid kernel pointer to > > be stored") changed the radix tree lookup so that it stops when > > reaching the bottom of the tree. But radix

Re: [PATCH] radix tree: Don't return internal entries on lookup

On Thu, Dec 06, 2018 at 08:54:03AM +0100, Greg Kurz wrote: > Commit 66ee620f06f9 ("idr: Permit any valid kernel pointer to > be stored") changed the radix tree lookup so that it stops when > reaching the bottom of the tree. But radix_tree_descend() may have > changed the node variable to point to a

[PATCH] radix tree: Don't return internal entries on lookup

Commit 66ee620f06f9 ("idr: Permit any valid kernel pointer to be stored") changed the radix tree lookup so that it stops when reaching the bottom of the tree. But radix_tree_descend() may have changed the node variable to point to an internal entry which then gets returned to the caller and bad thi