Re: [PATCH] rcu: Refactor rcu_{nmi,irq}_{enter,exit}()

2018-06-25 Thread Paul E. McKenney
On Mon, Jun 25, 2018 at 11:02:48AM -0400, Steven Rostedt wrote: > On Mon, 25 Jun 2018 07:48:49 -0700 > "Paul E. McKenney" wrote: > > > > > @@ -923,7 +932,7 @@ void rcu_user_exit(void) > > > > #endif /* CONFIG_NO_HZ_FULL */ > > > > > > > > /** > > > > - * rcu_nmi_enter - inform RCU of entry

Re: [PATCH] rcu: Refactor rcu_{nmi,irq}_{enter,exit}()

2018-06-25 Thread Paul E. McKenney
On Mon, Jun 25, 2018 at 11:02:48AM -0400, Steven Rostedt wrote: > On Mon, 25 Jun 2018 07:48:49 -0700 > "Paul E. McKenney" wrote: > > > > > @@ -923,7 +932,7 @@ void rcu_user_exit(void) > > > > #endif /* CONFIG_NO_HZ_FULL */ > > > > > > > > /** > > > > - * rcu_nmi_enter - inform RCU of entry

Re: [PATCH] rcu: Refactor rcu_{nmi,irq}_{enter,exit}()

2018-06-25 Thread Steven Rostedt
On Mon, 25 Jun 2018 07:48:49 -0700 "Paul E. McKenney" wrote: > > > @@ -923,7 +932,7 @@ void rcu_user_exit(void) > > > #endif /* CONFIG_NO_HZ_FULL */ > > > > > > /** > > > - * rcu_nmi_enter - inform RCU of entry to NMI context > > > + * rcu_nmi_enter_common - inform RCU of entry to NMI

Re: [PATCH] rcu: Refactor rcu_{nmi,irq}_{enter,exit}()

2018-06-25 Thread Steven Rostedt
On Mon, 25 Jun 2018 07:48:49 -0700 "Paul E. McKenney" wrote: > > > @@ -923,7 +932,7 @@ void rcu_user_exit(void) > > > #endif /* CONFIG_NO_HZ_FULL */ > > > > > > /** > > > - * rcu_nmi_enter - inform RCU of entry to NMI context > > > + * rcu_nmi_enter_common - inform RCU of entry to NMI

Re: [PATCH] rcu: Refactor rcu_{nmi,irq}_{enter,exit}()

2018-06-25 Thread Paul E. McKenney
On Mon, Jun 25, 2018 at 10:07:08AM -0400, Steven Rostedt wrote: > On Sat, 23 Jun 2018 10:49:54 -0700 > "Paul E. McKenney" wrote: > > > commit 5e5ea52645b197fb7ae2f59f7927079b91e91aa0 > > Author: Byungchul Park > > Date: Fri Jun 22 15:12:06 2018 +0900 > > > > rcu: Refactor

Re: [PATCH] rcu: Refactor rcu_{nmi,irq}_{enter,exit}()

2018-06-25 Thread Paul E. McKenney
On Mon, Jun 25, 2018 at 10:07:08AM -0400, Steven Rostedt wrote: > On Sat, 23 Jun 2018 10:49:54 -0700 > "Paul E. McKenney" wrote: > > > commit 5e5ea52645b197fb7ae2f59f7927079b91e91aa0 > > Author: Byungchul Park > > Date: Fri Jun 22 15:12:06 2018 +0900 > > > > rcu: Refactor

Re: [PATCH] rcu: Refactor rcu_{nmi,irq}_{enter,exit}()

2018-06-25 Thread Steven Rostedt
On Sat, 23 Jun 2018 10:49:54 -0700 "Paul E. McKenney" wrote: > commit 5e5ea52645b197fb7ae2f59f7927079b91e91aa0 > Author: Byungchul Park > Date: Fri Jun 22 15:12:06 2018 +0900 > > rcu: Refactor rcu_{nmi,irq}_{enter,exit}() > > When entering or exiting irq or NMI handlers, the

Re: [PATCH] rcu: Refactor rcu_{nmi,irq}_{enter,exit}()

2018-06-25 Thread Steven Rostedt
On Sat, 23 Jun 2018 10:49:54 -0700 "Paul E. McKenney" wrote: > commit 5e5ea52645b197fb7ae2f59f7927079b91e91aa0 > Author: Byungchul Park > Date: Fri Jun 22 15:12:06 2018 +0900 > > rcu: Refactor rcu_{nmi,irq}_{enter,exit}() > > When entering or exiting irq or NMI handlers, the

Re: [PATCH] rcu: Refactor rcu_{nmi,irq}_{enter,exit}()

2018-06-25 Thread Byungchul Park
On Sat, Jun 23, 2018 at 10:49:54AM -0700, Paul E. McKenney wrote: > On Fri, Jun 22, 2018 at 03:23:51PM +0900, Byungchul Park wrote: > > On Fri, Jun 22, 2018 at 03:12:06PM +0900, Byungchul Park wrote: > > > When passing through irq or NMI contexts, the current code uses > > > ->dynticks_nmi_nesting

Re: [PATCH] rcu: Refactor rcu_{nmi,irq}_{enter,exit}()

2018-06-25 Thread Byungchul Park
On Sat, Jun 23, 2018 at 10:49:54AM -0700, Paul E. McKenney wrote: > On Fri, Jun 22, 2018 at 03:23:51PM +0900, Byungchul Park wrote: > > On Fri, Jun 22, 2018 at 03:12:06PM +0900, Byungchul Park wrote: > > > When passing through irq or NMI contexts, the current code uses > > > ->dynticks_nmi_nesting

Re: [PATCH] rcu: Refactor rcu_{nmi,irq}_{enter,exit}()

2018-06-23 Thread Paul E. McKenney
On Fri, Jun 22, 2018 at 03:23:51PM +0900, Byungchul Park wrote: > On Fri, Jun 22, 2018 at 03:12:06PM +0900, Byungchul Park wrote: > > When passing through irq or NMI contexts, the current code uses > > ->dynticks_nmi_nesting to detect if it's in the ourmost at the moment. > > > > Here, the thing

Re: [PATCH] rcu: Refactor rcu_{nmi,irq}_{enter,exit}()

2018-06-23 Thread Paul E. McKenney
On Fri, Jun 22, 2018 at 03:23:51PM +0900, Byungchul Park wrote: > On Fri, Jun 22, 2018 at 03:12:06PM +0900, Byungchul Park wrote: > > When passing through irq or NMI contexts, the current code uses > > ->dynticks_nmi_nesting to detect if it's in the ourmost at the moment. > > > > Here, the thing

Re: [PATCH] rcu: Refactor rcu_{nmi,irq}_{enter,exit}()

2018-06-22 Thread Paul E. McKenney
On Fri, Jun 22, 2018 at 04:34:48PM +0800, kbuild test robot wrote: > Hi Byungchul, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on rcu/rcu/next] > [also build test WARNING on v4.18-rc1 next-20180622] > [if your patch is applied to the wrong git tree,

Re: [PATCH] rcu: Refactor rcu_{nmi,irq}_{enter,exit}()

2018-06-22 Thread Paul E. McKenney
On Fri, Jun 22, 2018 at 04:34:48PM +0800, kbuild test robot wrote: > Hi Byungchul, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on rcu/rcu/next] > [also build test WARNING on v4.18-rc1 next-20180622] > [if your patch is applied to the wrong git tree,

Re: [PATCH] rcu: Refactor rcu_{nmi,irq}_{enter,exit}()

2018-06-22 Thread kbuild test robot
Hi Byungchul, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on rcu/rcu/next] [also build test WARNING on v4.18-rc1 next-20180622] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] rcu: Refactor rcu_{nmi,irq}_{enter,exit}()

2018-06-22 Thread kbuild test robot
Hi Byungchul, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on rcu/rcu/next] [also build test WARNING on v4.18-rc1 next-20180622] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] rcu: Refactor rcu_{nmi,irq}_{enter,exit}()

2018-06-22 Thread Byungchul Park
On Fri, Jun 22, 2018 at 03:12:06PM +0900, Byungchul Park wrote: > When passing through irq or NMI contexts, the current code uses > ->dynticks_nmi_nesting to detect if it's in the ourmost at the moment. > > Here, the thing is that all the related functions, rcu_irq_enter(), > rcu_nmi_enter(),

Re: [PATCH] rcu: Refactor rcu_{nmi,irq}_{enter,exit}()

2018-06-22 Thread Byungchul Park
On Fri, Jun 22, 2018 at 03:12:06PM +0900, Byungchul Park wrote: > When passing through irq or NMI contexts, the current code uses > ->dynticks_nmi_nesting to detect if it's in the ourmost at the moment. > > Here, the thing is that all the related functions, rcu_irq_enter(), > rcu_nmi_enter(),

[PATCH] rcu: Refactor rcu_{nmi,irq}_{enter,exit}()

2018-06-22 Thread Byungchul Park
When passing through irq or NMI contexts, the current code uses ->dynticks_nmi_nesting to detect if it's in the ourmost at the moment. Here, the thing is that all the related functions, rcu_irq_enter(), rcu_nmi_enter(), rcu_irq_exit() and rcu_nmi_exit() are carrying out the check within each

[PATCH] rcu: Refactor rcu_{nmi,irq}_{enter,exit}()

2018-06-22 Thread Byungchul Park
When passing through irq or NMI contexts, the current code uses ->dynticks_nmi_nesting to detect if it's in the ourmost at the moment. Here, the thing is that all the related functions, rcu_irq_enter(), rcu_nmi_enter(), rcu_irq_exit() and rcu_nmi_exit() are carrying out the check within each