On Thu, Jun 22, 2017 at 07:36:29AM -0700, Paul E. McKenney wrote:
> On Thu, Jun 22, 2017 at 12:15:50AM +0200, Arnd Bergmann wrote:
> > On Thu, Jun 22, 2017 at 12:10 AM, Paul E. McKenney
> > wrote:
> > > On Wed, Jun 21, 2017 at 11:57:28PM +0200, Arnd Bergmann wrote:
> > >> Without CONFIG_SMP, we ge
On Thu, Jun 22, 2017 at 09:26:44AM +0200, Ingo Molnar wrote:
>
> * Paul E. McKenney wrote:
>
> > On Wed, Jun 21, 2017 at 11:57:28PM +0200, Arnd Bergmann wrote:
> > > Without CONFIG_SMP, we get a harmless warning about
> > > an unused variable:
> > >
> > > kernel/cpu.c: In function 'boot_cpu_sta
On Thu, Jun 22, 2017 at 12:15:50AM +0200, Arnd Bergmann wrote:
> On Thu, Jun 22, 2017 at 12:10 AM, Paul E. McKenney
> wrote:
> > On Wed, Jun 21, 2017 at 11:57:28PM +0200, Arnd Bergmann wrote:
> >> Without CONFIG_SMP, we get a harmless warning about
> >> an unused variable:
> >>
> >> kernel/cpu.c:
On Thu, Jun 22, 2017 at 11:02 AM, Ingo Molnar wrote:
>
> * Arnd Bergmann wrote:
>
>> On Thu, Jun 22, 2017 at 9:59 AM, Ingo Molnar wrote:
>> >
>> > So, to continue this side thought about uninitialized_var(), it is
>> > dangerous
>> > because the following buggy pattern does not generate a compi
* Arnd Bergmann wrote:
> On Thu, Jun 22, 2017 at 9:59 AM, Ingo Molnar wrote:
> >
> > So, to continue this side thought about uninitialized_var(), it is dangerous
> > because the following buggy pattern does not generate a compiler warning:
> >
> > long uninitialized_var(error);
> >
> >
On Thu, Jun 22, 2017 at 9:59 AM, Ingo Molnar wrote:
>
> So, to continue this side thought about uninitialized_var(), it is dangerous
> because the following buggy pattern does not generate a compiler warning:
>
> long uninitialized_var(error);
>
> ...
>
> if (error)
>
So, to continue this side thought about uninitialized_var(), it is dangerous
because the following buggy pattern does not generate a compiler warning:
long uninitialized_var(error);
...
if (error)
return error;
... and still there are over 290 uses of
* Ingo Molnar wrote:
>
> * Arnd Bergmann wrote:
>
> > > So I think we should consider it a syntactic construct to avoid.
> >
> > Unused variables are relatively harmless compared to used-uninitialized
> > variables that are always bugs (though they are provably impossible to
> > detect corre
* Arnd Bergmann wrote:
> > So I think we should consider it a syntactic construct to avoid.
>
> Unused variables are relatively harmless compared to used-uninitialized
> variables that are always bugs (though they are provably impossible to
> detect correctly in some cases).
So the thing I was
On Thu, Jun 22, 2017 at 9:26 AM, Ingo Molnar wrote:
>
> * Paul E. McKenney wrote:
>
>> On Wed, Jun 21, 2017 at 11:57:28PM +0200, Arnd Bergmann wrote:
>> > Without CONFIG_SMP, we get a harmless warning about
>> > an unused variable:
>> >
>> > kernel/cpu.c: In function 'boot_cpu_state_init':
>> > k
* Paul E. McKenney wrote:
> On Wed, Jun 21, 2017 at 11:57:28PM +0200, Arnd Bergmann wrote:
> > Without CONFIG_SMP, we get a harmless warning about
> > an unused variable:
> >
> > kernel/cpu.c: In function 'boot_cpu_state_init':
> > kernel/cpu.c:1778:6: error: unused variable 'cpu' [-Werror=unus
On Thu, Jun 22, 2017 at 12:10 AM, Paul E. McKenney
wrote:
> On Wed, Jun 21, 2017 at 11:57:28PM +0200, Arnd Bergmann wrote:
>> Without CONFIG_SMP, we get a harmless warning about
>> an unused variable:
>>
>> kernel/cpu.c: In function 'boot_cpu_state_init':
>> kernel/cpu.c:1778:6: error: unused vari
On Wed, Jun 21, 2017 at 11:57:28PM +0200, Arnd Bergmann wrote:
> Without CONFIG_SMP, we get a harmless warning about
> an unused variable:
>
> kernel/cpu.c: In function 'boot_cpu_state_init':
> kernel/cpu.c:1778:6: error: unused variable 'cpu' [-Werror=unused-variable]
>
> This reworks the functi
Without CONFIG_SMP, we get a harmless warning about
an unused variable:
kernel/cpu.c: In function 'boot_cpu_state_init':
kernel/cpu.c:1778:6: error: unused variable 'cpu' [-Werror=unused-variable]
This reworks the function to have the declaration inside
of the #ifdef.
Fixes: faeb334286b7 ("rcu:
14 matches
Mail list logo