Re: [PATCH] regmap: don't corrupt work buffer in _regmap_raw_write()

2013-04-08 Thread Stephen Warren
On 04/08/2013 06:01 AM, Mark Brown wrote: > On Mon, Apr 08, 2013 at 12:24:22PM +0200, Paul Bolle wrote: > >> 0) This patch ended up as mainline commit >> bc8ce4afd7ee7e1421c935d24b1f879f82afdd4e, which is part of >> v3.9-rc6. > > Numbering your paragraphs and using full commit IDs like this > do

Re: [PATCH] regmap: don't corrupt work buffer in _regmap_raw_write()

2013-04-08 Thread Mark Brown
On Mon, Apr 08, 2013 at 12:24:22PM +0200, Paul Bolle wrote: > 0) This patch ended up as mainline commit > bc8ce4afd7ee7e1421c935d24b1f879f82afdd4e, which is part of v3.9-rc6. Numbering your paragraphs and using full commit IDs like this doesn't help with legibility... > 2) The following (draft)

Re: [PATCH] regmap: don't corrupt work buffer in _regmap_raw_write()

2013-04-08 Thread Paul Bolle
On Thu, 2013-03-21 at 20:09 +0100, Mark Brown wrote: > On Wed, Mar 20, 2013 at 05:02:02PM -0600, Stephen Warren wrote: > > _regmap_raw_write() contains code to call regcache_write() to write > > values to the cache. That code calls memcpy() to copy the value data to > > the start of the work_buf. H

Re: [PATCH] regmap: don't corrupt work buffer in _regmap_raw_write()

2013-03-21 Thread Mark Brown
On Wed, Mar 20, 2013 at 05:02:02PM -0600, Stephen Warren wrote: > From: Stephen Warren > > _regmap_raw_write() contains code to call regcache_write() to write > values to the cache. That code calls memcpy() to copy the value data to > the start of the work_buf. However, at least when _regmap_raw_

[PATCH] regmap: don't corrupt work buffer in _regmap_raw_write()

2013-03-20 Thread Stephen Warren
From: Stephen Warren _regmap_raw_write() contains code to call regcache_write() to write values to the cache. That code calls memcpy() to copy the value data to the start of the work_buf. However, at least when _regmap_raw_write() is called from _regmap_bus_raw_write(), the value data is in the w