Re: [PATCH] regmap: fix of_regmap_get_endian()

2014-08-19 Thread Stephen Warren
On 08/19/2014 09:34 AM, Mark Brown wrote: On Mon, Aug 18, 2014 at 04:14:04PM -0600, Stephen Warren wrote: From: Stephen Warren Commit d647c199510c ("regmap: add DT endianness binding support") has some issues. Specifically, if config->reg_format_endian is not explicitly set, it will be zero,

Re: [PATCH] regmap: fix of_regmap_get_endian()

2014-08-19 Thread Mark Brown
On Mon, Aug 18, 2014 at 04:14:04PM -0600, Stephen Warren wrote: > From: Stephen Warren > > Commit d647c199510c ("regmap: add DT endianness binding support") has > some issues. Specifically, if config->reg_format_endian is not explicitly > set, it will be zero, i.e. REGMAP_ENDIAN_DEFAULT. The

Re: [PATCH] regmap: fix of_regmap_get_endian()

2014-08-19 Thread Mark Brown
On Mon, Aug 18, 2014 at 04:14:04PM -0600, Stephen Warren wrote: From: Stephen Warren swar...@nvidia.com Commit d647c199510c (regmap: add DT endianness binding support) has some issues. Specifically, if config-reg_format_endian is not explicitly set, it will be zero, i.e.

Re: [PATCH] regmap: fix of_regmap_get_endian()

2014-08-19 Thread Stephen Warren
On 08/19/2014 09:34 AM, Mark Brown wrote: On Mon, Aug 18, 2014 at 04:14:04PM -0600, Stephen Warren wrote: From: Stephen Warren swar...@nvidia.com Commit d647c199510c (regmap: add DT endianness binding support) has some issues. Specifically, if config-reg_format_endian is not explicitly set, it

RE: [PATCH] regmap: fix of_regmap_get_endian()

2014-08-18 Thread li.xi...@freescale.com
August 19, 2014 1:22 PM > To: Stephen Warren > Cc: Mark Brown; Thierry Reding; linux-kernel@vger.kernel.org; linux- > n...@vger.kernel.org; Stephen Warren; Xiubo Li-B47053 > Subject: Re: [PATCH] regmap: fix of_regmap_get_endian() > > On Mon, Aug 18, 2014 at 04:14:04PM -0600, Ste

Re: [PATCH] regmap: fix of_regmap_get_endian()

2014-08-18 Thread Thierry Reding
On Mon, Aug 18, 2014 at 04:14:04PM -0600, Stephen Warren wrote: > From: Stephen Warren > > Commit d647c199510c ("regmap: add DT endianness binding support") has > some issues. Specifically, if config->reg_format_endian is not explicitly > set, it will be zero, i.e. REGMAP_ENDIAN_DEFAULT. The

[PATCH] regmap: fix of_regmap_get_endian()

2014-08-18 Thread Stephen Warren
From: Stephen Warren Commit d647c199510c ("regmap: add DT endianness binding support") has some issues. Specifically, if config->reg_format_endian is not explicitly set, it will be zero, i.e. REGMAP_ENDIAN_DEFAULT. The switch statement that looks up the *endian from DT for the

[PATCH] regmap: fix of_regmap_get_endian()

2014-08-18 Thread Stephen Warren
From: Stephen Warren swar...@nvidia.com Commit d647c199510c (regmap: add DT endianness binding support) has some issues. Specifically, if config-reg_format_endian is not explicitly set, it will be zero, i.e. REGMAP_ENDIAN_DEFAULT. The switch statement that looks up the *endian from DT for the

Re: [PATCH] regmap: fix of_regmap_get_endian()

2014-08-18 Thread Thierry Reding
On Mon, Aug 18, 2014 at 04:14:04PM -0600, Stephen Warren wrote: From: Stephen Warren swar...@nvidia.com Commit d647c199510c (regmap: add DT endianness binding support) has some issues. Specifically, if config-reg_format_endian is not explicitly set, it will be zero, i.e.

RE: [PATCH] regmap: fix of_regmap_get_endian()

2014-08-18 Thread li.xi...@freescale.com
, 2014 1:22 PM To: Stephen Warren Cc: Mark Brown; Thierry Reding; linux-kernel@vger.kernel.org; linux- n...@vger.kernel.org; Stephen Warren; Xiubo Li-B47053 Subject: Re: [PATCH] regmap: fix of_regmap_get_endian() On Mon, Aug 18, 2014 at 04:14:04PM -0600, Stephen Warren wrote: From: Stephen