Re: [PATCH] regmap: regmap-irq/gpio-max77620: add level-irq support

2018-12-11 Thread Matti Vaittinen
Hello Again All, Sorry for multiple posts but I had second look at this and... On Tue, Dec 11, 2018 at 08:38:25AM +0200, Matti Vaittinen wrote: > Hello Vladimir, > > Thanks for the review. > > On Mon, Dec 10, 2018 at 05:16:28PM +0200, Vladimir Zapolskiy wrote: > > On 12/10/2018 10:14 AM, Matti

Re: [PATCH] regmap: regmap-irq/gpio-max77620: add level-irq support

2018-12-10 Thread Matti Vaittinen
Hello Vladimir, Thanks for the review. On Mon, Dec 10, 2018 at 05:16:28PM +0200, Vladimir Zapolskiy wrote: > On 12/10/2018 10:14 AM, Matti Vaittinen wrote: > > Add level active IRQ support to regmap-irq irqchip. Change breaks > > existing regmap-irq type setting. Convert the existing drivers

Re: [PATCH] regmap: regmap-irq/gpio-max77620: add level-irq support

2018-12-10 Thread Vladimir Zapolskiy
On 12/10/2018 10:14 AM, Matti Vaittinen wrote: > Add level active IRQ support to regmap-irq irqchip. Change breaks > existing regmap-irq type setting. Convert the existing drivers which > use regmap-irq with trigger type setting (gpio-max77620) to work > with this new approach. So we do not

RE: [PATCH] regmap: regmap-irq/gpio-max77620: add level-irq support

2018-12-10 Thread Vaittinen, Matti
...@linaro.org; linux-kernel@vger.kernel.org; linux-g...@vger.kernel.org; Haikola, Heikki; Mutanen, Mikko Subject: Re: [PATCH] regmap: regmap-irq/gpio-max77620: add level-irq support > Hi Matti, > >Thank you for the patch! Yet something to improve: >> drivers/gpio/gpio-max77620.c:33:40:

Re: [PATCH] regmap: regmap-irq/gpio-max77620: add level-irq support

2018-12-10 Thread kbuild test robot
Hi Matti, Thank you for the patch! Yet something to improve: [auto build test ERROR on gpio/for-next] [also build test ERROR on v4.20-rc6 next-20181207] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH] regmap: regmap-irq/gpio-max77620: add level-irq support

2018-12-10 Thread Matti Vaittinen
Add level active IRQ support to regmap-irq irqchip. Change breaks existing regmap-irq type setting. Convert the existing drivers which use regmap-irq with trigger type setting (gpio-max77620) to work with this new approach. So we do not magically support level-active IRQs on gpio-max77620 - but