Re: [PATCH] regulator: TPS51632: Add tps51632 regulator driver

2012-10-09 Thread Laxman Dewangan
On Tuesday 09 October 2012 11:44 AM, Mark Brown wrote: On Sat, Oct 06, 2012 at 08:47:46PM +0530, Laxman Dewangan wrote: Actually... + if (pdata->dvfs_step_20mV) + control |= TPS51632_DVFS_STEP_20; + tps->desc.uV_step = TPS51632_VOLATGE_STEP_10mV; Shouldn't the

Re: [PATCH] regulator: TPS51632: Add tps51632 regulator driver

2012-10-09 Thread Mark Brown
On Sat, Oct 06, 2012 at 08:47:46PM +0530, Laxman Dewangan wrote: Actually... > + if (pdata->dvfs_step_20mV) > + control |= TPS51632_DVFS_STEP_20; > + tps->desc.uV_step = TPS51632_VOLATGE_STEP_10mV; Shouldn't the dvfs_step_20mV setting affect the uV_step size? -- To

Re: [PATCH] regulator: TPS51632: Add tps51632 regulator driver

2012-10-09 Thread Mark Brown
On Sat, Oct 06, 2012 at 08:47:46PM +0530, Laxman Dewangan wrote: Actually... + if (pdata-dvfs_step_20mV) + control |= TPS51632_DVFS_STEP_20; + tps-desc.uV_step = TPS51632_VOLATGE_STEP_10mV; Shouldn't the dvfs_step_20mV setting affect the uV_step size? -- To unsubscribe

Re: [PATCH] regulator: TPS51632: Add tps51632 regulator driver

2012-10-09 Thread Laxman Dewangan
On Tuesday 09 October 2012 11:44 AM, Mark Brown wrote: On Sat, Oct 06, 2012 at 08:47:46PM +0530, Laxman Dewangan wrote: Actually... + if (pdata-dvfs_step_20mV) + control |= TPS51632_DVFS_STEP_20; + tps-desc.uV_step = TPS51632_VOLATGE_STEP_10mV; Shouldn't the

[PATCH] regulator: TPS51632: Add tps51632 regulator driver

2012-10-06 Thread Laxman Dewangan
The TPS51632 is a driverless step down controller with serial control. Advanced features such as D-Cap+ architecture with overlapping pulse support and OSR overshoot reduction provide fast transient response, lowest output capacitance and high efficiency. The TPS51632 supports both I2C and DVFS

[PATCH] regulator: TPS51632: Add tps51632 regulator driver

2012-10-06 Thread Laxman Dewangan
The TPS51632 is a driverless step down controller with serial control. Advanced features such as D-Cap+ architecture with overlapping pulse support and OSR overshoot reduction provide fast transient response, lowest output capacitance and high efficiency. The TPS51632 supports both I2C and DVFS