Re: [PATCH] regulator: fixed: Use devm_regulator_register

2014-01-26 Thread Manish Badarkhe
Hi On Mon, Jan 27, 2014 at 5:33 AM, Mark Brown wrote: > On Sun, Jan 26, 2014 at 01:36:53PM -0800, Dmitry Torokhov wrote: >> On Sat, Jan 25, 2014 at 11:35:54PM +0530, Manish Badarkhe wrote: > >> > Use "devm_regulator_register" instead of "regulator_register" >> > which simplifies the code. > >>

Re: [PATCH] regulator: fixed: Use devm_regulator_register

2014-01-26 Thread Mark Brown
On Sun, Jan 26, 2014 at 01:36:53PM -0800, Dmitry Torokhov wrote: > On Sat, Jan 25, 2014 at 11:35:54PM +0530, Manish Badarkhe wrote: > > Use "devm_regulator_register" instead of "regulator_register" > > which simplifies the code. > ... and also breaks the driver: now you are freeing desc->name

Re: [PATCH] regulator: fixed: Use devm_regulator_register

2014-01-26 Thread Dmitry Torokhov
Hi Manish, On Sat, Jan 25, 2014 at 11:35:54PM +0530, Manish Badarkhe wrote: > Use "devm_regulator_register" instead of "regulator_register" > which simplifies the code. ... and also breaks the driver: now you are freeing desc->name and desc->supply_name while regulator structures are still alive

Re: [PATCH] regulator: fixed: Use devm_regulator_register

2014-01-26 Thread Dmitry Torokhov
Hi Manish, On Sat, Jan 25, 2014 at 11:35:54PM +0530, Manish Badarkhe wrote: Use devm_regulator_register instead of regulator_register which simplifies the code. ... and also breaks the driver: now you are freeing desc-name and desc-supply_name while regulator structures are still alive and can

Re: [PATCH] regulator: fixed: Use devm_regulator_register

2014-01-26 Thread Mark Brown
On Sun, Jan 26, 2014 at 01:36:53PM -0800, Dmitry Torokhov wrote: On Sat, Jan 25, 2014 at 11:35:54PM +0530, Manish Badarkhe wrote: Use devm_regulator_register instead of regulator_register which simplifies the code. ... and also breaks the driver: now you are freeing desc-name and

Re: [PATCH] regulator: fixed: Use devm_regulator_register

2014-01-26 Thread Manish Badarkhe
Hi On Mon, Jan 27, 2014 at 5:33 AM, Mark Brown broo...@kernel.org wrote: On Sun, Jan 26, 2014 at 01:36:53PM -0800, Dmitry Torokhov wrote: On Sat, Jan 25, 2014 at 11:35:54PM +0530, Manish Badarkhe wrote: Use devm_regulator_register instead of regulator_register which simplifies the code.

[PATCH] regulator: fixed: Use devm_regulator_register

2014-01-25 Thread Manish Badarkhe
Use "devm_regulator_register" instead of "regulator_register" which simplifies the code. Signed-off-by: Manish Badarkhe --- :100644 100644 5ea64b9... 6d32341... M drivers/regulator/fixed.c drivers/regulator/fixed.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] regulator: fixed: Use devm_regulator_register

2014-01-25 Thread Manish Badarkhe
Use devm_regulator_register instead of regulator_register which simplifies the code. Signed-off-by: Manish Badarkhe badarkhe.man...@gmail.com --- :100644 100644 5ea64b9... 6d32341... M drivers/regulator/fixed.c drivers/regulator/fixed.c |4 ++-- 1 file changed, 2 insertions(+), 2