Re: [PATCH] regulator: max8997: skip gpio dvs setup if not used

2012-11-22 Thread Thomas Abraham
Dear Mr. Ham, Thanks for your comments. On 21 November 2012 20:01, MyungJoo Ham wrote: > On Wed, Nov 21, 2012 at 11:23 PM, Thomas Abraham > wrote: >> If gpio based voltage selection for buck 1/2/5 are not used, then the >> execution >> of gpio dvs setup code during probe can be skipped

Re: [PATCH] regulator: max8997: skip gpio dvs setup if not used

2012-11-22 Thread Thomas Abraham
Dear Mr. Ham, Thanks for your comments. On 21 November 2012 20:01, MyungJoo Ham myungjoo@samsung.com wrote: On Wed, Nov 21, 2012 at 11:23 PM, Thomas Abraham thomas.abra...@linaro.org wrote: If gpio based voltage selection for buck 1/2/5 are not used, then the execution of gpio dvs

Re: [PATCH] regulator: max8997: skip gpio dvs setup if not used

2012-11-21 Thread MyungJoo Ham
On Wed, Nov 21, 2012 at 11:23 PM, Thomas Abraham wrote: > If gpio based voltage selection for buck 1/2/5 are not used, then the > execution > of gpio dvs setup code during probe can be skipped completly. Even if GPIO-DVS feature is turned off, you need to setup BUCKxDVS1 anyway. Otherwise, you

[PATCH] regulator: max8997: skip gpio dvs setup if not used

2012-11-21 Thread Thomas Abraham
If gpio based voltage selection for buck 1/2/5 are not used, then the execution of gpio dvs setup code during probe can be skipped completly. Cc: MyungJoo Ham Cc: Mark Brown Signed-off-by: Thomas Abraham --- drivers/regulator/max8997.c | 31 ++- 1 files changed,

[PATCH] regulator: max8997: skip gpio dvs setup if not used

2012-11-21 Thread Thomas Abraham
If gpio based voltage selection for buck 1/2/5 are not used, then the execution of gpio dvs setup code during probe can be skipped completly. Cc: MyungJoo Ham myungjoo@samsung.com Cc: Mark Brown broo...@opensource.wolfsonmicro.com Signed-off-by: Thomas Abraham thomas.abra...@linaro.org ---

Re: [PATCH] regulator: max8997: skip gpio dvs setup if not used

2012-11-21 Thread MyungJoo Ham
On Wed, Nov 21, 2012 at 11:23 PM, Thomas Abraham thomas.abra...@linaro.org wrote: If gpio based voltage selection for buck 1/2/5 are not used, then the execution of gpio dvs setup code during probe can be skipped completly. Even if GPIO-DVS feature is turned off, you need to setup BUCKxDVS1