Re: [PATCH] regulator: of: simplifing the parsing code

2015-11-22 Thread Mark Brown
On Sat, Nov 21, 2015 at 07:41:54PM +0530, Saurabh Sengar wrote: > On 21 November 2015 at 18:52, Mark Brown wrote: > > On Fri, Nov 20, 2015 at 01:27:27PM +0530, Saurabh Sengar wrote: > > No, they can't - the values we set for modes in the DT are defined per > > regulator and we need to translate

Re: [PATCH] regulator: of: simplifing the parsing code

2015-11-22 Thread Mark Brown
On Sat, Nov 21, 2015 at 07:41:54PM +0530, Saurabh Sengar wrote: > On 21 November 2015 at 18:52, Mark Brown wrote: > > On Fri, Nov 20, 2015 at 01:27:27PM +0530, Saurabh Sengar wrote: > > No, they can't - the values we set for modes in the DT are defined per > > regulator and

Re: [PATCH] regulator: of: simplifing the parsing code

2015-11-21 Thread Saurabh Sengar
On 21 November 2015 at 18:52, Mark Brown wrote: > On Fri, Nov 20, 2015 at 01:27:27PM +0530, Saurabh Sengar wrote: > >> I also have concern related to how we are passing 'regulator-mode' and >> 'regulator-initial-mode'. Currently this require a extra function to be >> set in 'of_map_mode', which

Re: [PATCH] regulator: of: simplifing the parsing code

2015-11-21 Thread Mark Brown
On Fri, Nov 20, 2015 at 01:27:27PM +0530, Saurabh Sengar wrote: > in case of_property_read_u32 fails, it keeps the parameter unchanged > so no need to test if its success and then assign the value On the other hand the current code doesn't require us to know that detail... it's really not

Re: [PATCH] regulator: of: simplifing the parsing code

2015-11-21 Thread Mark Brown
On Fri, Nov 20, 2015 at 01:27:27PM +0530, Saurabh Sengar wrote: > in case of_property_read_u32 fails, it keeps the parameter unchanged > so no need to test if its success and then assign the value On the other hand the current code doesn't require us to know that detail... it's really not

Re: [PATCH] regulator: of: simplifing the parsing code

2015-11-21 Thread Saurabh Sengar
On 21 November 2015 at 18:52, Mark Brown wrote: > On Fri, Nov 20, 2015 at 01:27:27PM +0530, Saurabh Sengar wrote: > >> I also have concern related to how we are passing 'regulator-mode' and >> 'regulator-initial-mode'. Currently this require a extra function to be >> set in

[PATCH] regulator: of: simplifing the parsing code

2015-11-19 Thread Saurabh Sengar
in case of_property_read_u32 fails, it keeps the parameter unchanged so no need to test if its success and then assign the value Signed-off-by: Saurabh Sengar --- Hi Mark, I also have concern related to how we are passing 'regulator-mode' and 'regulator-initial-mode'. Currently this require a

[PATCH] regulator: of: simplifing the parsing code

2015-11-19 Thread Saurabh Sengar
in case of_property_read_u32 fails, it keeps the parameter unchanged so no need to test if its success and then assign the value Signed-off-by: Saurabh Sengar --- Hi Mark, I also have concern related to how we are passing 'regulator-mode' and 'regulator-initial-mode'.