Re: [PATCH] regulator: qcom_spmi: Improve readability for setting up enable/mode pin control

2020-08-18 Thread Mark Brown
On Sat, 1 Aug 2020 13:48:20 +0800, Axel Lin wrote: > By checking data->pin_ctrl_enable / data->pin_ctrl_hpm flags first, then > use switch-case to improve readability. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next Thanks! [1/1] regulator:

Re: [PATCH] regulator: qcom_spmi: Improve readability for setting up enable/mode pin control

2020-08-01 Thread Bjorn Andersson
On Fri 31 Jul 22:48 PDT 2020, Axel Lin wrote: > By checking data->pin_ctrl_enable / data->pin_ctrl_hpm flags first, then > use switch-case to improve readability. > Nice! Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Axel Lin > --- > drivers/regulator/qcom_spmi-regulator.c

[PATCH] regulator: qcom_spmi: Improve readability for setting up enable/mode pin control

2020-07-31 Thread Axel Lin
By checking data->pin_ctrl_enable / data->pin_ctrl_hpm flags first, then use switch-case to improve readability. Signed-off-by: Axel Lin --- drivers/regulator/qcom_spmi-regulator.c | 70 - 1 file changed, 34 insertions(+), 36 deletions(-) diff --git