Re: [PATCH] remoteproc: qcom: q6v5: shore up resource probe handling

2018-10-10 Thread Bjorn Andersson
On Tue 09 Oct 16:34 PDT 2018, Doug Anderson wrote: > Hi, > > On Tue, Oct 9, 2018 at 3:33 PM Brian Norris wrote: > > + if (q6v5->wdog_irq < 0) { > > + if (q6v5->wdog_irq != -EPROBE_DEFER) > > + dev_err(>dev, > > + "failed to

Re: [PATCH] remoteproc: qcom: q6v5: shore up resource probe handling

2018-10-10 Thread Bjorn Andersson
On Tue 09 Oct 16:34 PDT 2018, Doug Anderson wrote: > Hi, > > On Tue, Oct 9, 2018 at 3:33 PM Brian Norris wrote: > > + if (q6v5->wdog_irq < 0) { > > + if (q6v5->wdog_irq != -EPROBE_DEFER) > > + dev_err(>dev, > > + "failed to

Re: [PATCH] remoteproc: qcom: q6v5: shore up resource probe handling

2018-10-09 Thread Brian Norris
On Tue, Oct 9, 2018 at 4:34 PM Doug Anderson wrote: > On Tue, Oct 9, 2018 at 3:33 PM Brian Norris wrote: > > + if (q6v5->wdog_irq < 0) { > > + if (q6v5->wdog_irq != -EPROBE_DEFER) > > + dev_err(>dev, > > + "failed to

Re: [PATCH] remoteproc: qcom: q6v5: shore up resource probe handling

2018-10-09 Thread Brian Norris
On Tue, Oct 9, 2018 at 4:34 PM Doug Anderson wrote: > On Tue, Oct 9, 2018 at 3:33 PM Brian Norris wrote: > > + if (q6v5->wdog_irq < 0) { > > + if (q6v5->wdog_irq != -EPROBE_DEFER) > > + dev_err(>dev, > > + "failed to

Re: [PATCH] remoteproc: qcom: q6v5: shore up resource probe handling

2018-10-09 Thread Doug Anderson
Hi, On Tue, Oct 9, 2018 at 3:33 PM Brian Norris wrote: > + if (q6v5->wdog_irq < 0) { > + if (q6v5->wdog_irq != -EPROBE_DEFER) > + dev_err(>dev, > + "failed to retrieve wdog IRQ: %d\n", > +

Re: [PATCH] remoteproc: qcom: q6v5: shore up resource probe handling

2018-10-09 Thread Doug Anderson
Hi, On Tue, Oct 9, 2018 at 3:33 PM Brian Norris wrote: > + if (q6v5->wdog_irq < 0) { > + if (q6v5->wdog_irq != -EPROBE_DEFER) > + dev_err(>dev, > + "failed to retrieve wdog IRQ: %d\n", > +

[PATCH] remoteproc: qcom: q6v5: shore up resource probe handling

2018-10-09 Thread Brian Norris
Commit d5269c4553a6 ("remoteproc: qcom: q6v5: Propagate EPROBE_DEFER") fixed up our probe code to handle -EPROBE_DEFER, but it ignored one of our interrupts, and it also didn't really handle all the other error codes you might get (e.g., with a bad DT definition). Handle those all explicitly.

[PATCH] remoteproc: qcom: q6v5: shore up resource probe handling

2018-10-09 Thread Brian Norris
Commit d5269c4553a6 ("remoteproc: qcom: q6v5: Propagate EPROBE_DEFER") fixed up our probe code to handle -EPROBE_DEFER, but it ignored one of our interrupts, and it also didn't really handle all the other error codes you might get (e.g., with a bad DT definition). Handle those all explicitly.