Re: [PATCH] revoke: delayed file closing

2007-03-09 Thread Pekka Enberg
On 3/9/07, Pekka J Enberg <[EMAIL PROTECTED]> wrote: To fix this, change sys_revoke() not to close the actual revoked file immediately. Instead, we do filp_close() when the user does close(2) on the revoked file descriptor. Btw, this is safe because a filesystem implementing f_ops->revoke must

[PATCH] revoke: delayed file closing

2007-03-09 Thread Pekka J Enberg
From: Pekka Enberg <[EMAIL PROTECTED]> As explained by Eric Dumazet, one of the interests of fget_light() is to avoid dirtying struct file which is broken by the newly added file->f_light. In addition, fget_light() currently has a race window between fcheck_files() and set_f_light(). To fix

[PATCH] revoke: delayed file closing

2007-03-09 Thread Pekka J Enberg
From: Pekka Enberg [EMAIL PROTECTED] As explained by Eric Dumazet, one of the interests of fget_light() is to avoid dirtying struct file which is broken by the newly added file-f_light. In addition, fget_light() currently has a race window between fcheck_files() and set_f_light(). To fix this,

Re: [PATCH] revoke: delayed file closing

2007-03-09 Thread Pekka Enberg
On 3/9/07, Pekka J Enberg [EMAIL PROTECTED] wrote: To fix this, change sys_revoke() not to close the actual revoked file immediately. Instead, we do filp_close() when the user does close(2) on the revoked file descriptor. Btw, this is safe because a filesystem implementing f_ops-revoke must