Re: [PATCH] riscv: Fixed kernel test robot warning
On Tue, 08 Dec 2020 12:22:46 PST (-0800), sch...@linux-m68k.org wrote: On Dez 09 2020, Souptick Joarder wrote: On Wed, Dec 9, 2020 at 1:21 AM Andreas Schwab wrote: On Dez 09 2020, Souptick Joarder wrote: > Kernel test robot throws below warning - > >arch/riscv/kernel/asm-offsets.c:14:6: warning: no previous prototype > for 'asm_offsets' [-Wmissing-prototypes] > 14 | void asm_offsets(void) > | ^~~ > > This patch should fixed it. Or rename it to main, like most other asm-offsets files. Few asm-offsets files named it as foo(). Does a rename to main() will work straight forward ? Calling it main will suppress the warning, but other than that it is completely irrelevant how you call it. Ya, I think it doesn't really matter so I'm just going to take this as is. It's on for-next (being a bit paranoid, as we're so late in the cycle).
[PATCH] riscv: Fixed kernel test robot warning
Kernel test robot throws below warning -
arch/riscv/kernel/asm-offsets.c:14:6: warning: no previous prototype
for 'asm_offsets' [-Wmissing-prototypes]
14 | void asm_offsets(void)
| ^~~
This patch should fixed it.
Reported-by: kernel test robot
Signed-off-by: Souptick Joarder
---
arch/riscv/kernel/asm-offsets.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/riscv/kernel/asm-offsets.c b/arch/riscv/kernel/asm-offsets.c
index db20344..b79ffa3 100644
--- a/arch/riscv/kernel/asm-offsets.c
+++ b/arch/riscv/kernel/asm-offsets.c
@@ -11,6 +11,8 @@
#include
#include
+void asm_offsets(void);
+
void asm_offsets(void)
{
OFFSET(TASK_THREAD_RA, task_struct, thread.ra);
--
1.9.1
Re: [PATCH] riscv: Fixed kernel test robot warning
On Dez 09 2020, Souptick Joarder wrote: > Kernel test robot throws below warning - > >arch/riscv/kernel/asm-offsets.c:14:6: warning: no previous prototype > for 'asm_offsets' [-Wmissing-prototypes] > 14 | void asm_offsets(void) > | ^~~ > > This patch should fixed it. Or rename it to main, like most other asm-offsets files. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."
Re: [PATCH] riscv: Fixed kernel test robot warning
On Dez 09 2020, Souptick Joarder wrote: > On Wed, Dec 9, 2020 at 1:21 AM Andreas Schwab wrote: >> >> On Dez 09 2020, Souptick Joarder wrote: >> >> > Kernel test robot throws below warning - >> > >> >arch/riscv/kernel/asm-offsets.c:14:6: warning: no previous prototype >> > for 'asm_offsets' [-Wmissing-prototypes] >> > 14 | void asm_offsets(void) >> > | ^~~ >> > >> > This patch should fixed it. >> >> Or rename it to main, like most other asm-offsets files. > > Few asm-offsets files named it as foo(). Does a rename to main() will > work straight forward ? Calling it main will suppress the warning, but other than that it is completely irrelevant how you call it. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."
Re: [PATCH] riscv: Fixed kernel test robot warning
On Wed, Dec 9, 2020 at 1:21 AM Andreas Schwab wrote: > > On Dez 09 2020, Souptick Joarder wrote: > > > Kernel test robot throws below warning - > > > >arch/riscv/kernel/asm-offsets.c:14:6: warning: no previous prototype > > for 'asm_offsets' [-Wmissing-prototypes] > > 14 | void asm_offsets(void) > > | ^~~ > > > > This patch should fixed it. > > Or rename it to main, like most other asm-offsets files. Few asm-offsets files named it as foo(). Does a rename to main() will work straight forward ? I don't know much about this area of code. > > Andreas. > > -- > Andreas Schwab, sch...@linux-m68k.org > GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 > "And now for something completely different."
